Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2547513002: Fix the data reduction proxy builder for Cronet (Closed)

Created:
4 years ago by tbansal1
Modified:
4 years ago
Reviewers:
sclittle
CC:
chromium-reviews, tbansal+watch-data-reduction-proxy_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the data reduction proxy builder for Cronet This is a partial revert of https://codereview.chromium.org/2504963004 which broke Cronet data reduction proxy builder. The original CL passed the CQ because the Cronet builder has been down for 4-5 days. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester BUG=669037 TBR=sclittle@chromium.org Committed: https://crrev.com/1b81c5896da9ff3718b3001080f914b3adf44eb0 Cr-Commit-Position: refs/heads/master@{#435602}

Patch Set 1 #

Messages

Total messages: 18 (13 generated)
tbansal1
sclittle: ptal. I am going to TBR this so the broken bot is fixed sooner ...
4 years ago (2016-12-01 13:57:15 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2547513002/1
4 years ago (2016-12-01 13:58:06 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 14:02:50 UTC) #15
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1b81c5896da9ff3718b3001080f914b3adf44eb0 Cr-Commit-Position: refs/heads/master@{#435602}
4 years ago (2016-12-01 14:06:34 UTC) #17
sclittle
4 years ago (2016-12-01 20:38:27 UTC) #18
Message was sent while issue was closed.
LGTM fwiw

Powered by Google App Engine
This is Rietveld 408576698