Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: test/cctest/heap/test-heap.cc

Issue 2547483002: Store SharedFunctionInfos of a Script in a FixedArray indexed by their ID (Closed)
Patch Set: updates Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 6380 matching lines...) Expand 10 before | Expand all | Expand 10 after
6391 int sfi_count = 0; 6391 int sfi_count = 0;
6392 { 6392 {
6393 HeapIterator it(heap); 6393 HeapIterator it(heap);
6394 for (HeapObject* obj = it.next(); obj != NULL; obj = it.next()) { 6394 for (HeapObject* obj = it.next(); obj != NULL; obj = it.next()) {
6395 if (!obj->IsSharedFunctionInfo()) continue; 6395 if (!obj->IsSharedFunctionInfo()) continue;
6396 sfi_count++; 6396 sfi_count++;
6397 } 6397 }
6398 } 6398 }
6399 6399
6400 { 6400 {
6401 SharedFunctionInfo::Iterator iterator(isolate); 6401 SharedFunctionInfo::GlobalIterator iterator(isolate);
6402 while (iterator.Next()) sfi_count--; 6402 while (iterator.Next()) sfi_count--;
6403 } 6403 }
6404 6404
6405 CHECK_EQ(0, sfi_count); 6405 CHECK_EQ(0, sfi_count);
6406 } 6406 }
6407 6407
6408 6408
6409 template <typename T> 6409 template <typename T>
6410 static UniqueId MakeUniqueId(const Persistent<T>& p) { 6410 static UniqueId MakeUniqueId(const Persistent<T>& p) {
6411 return UniqueId(reinterpret_cast<uintptr_t>(*v8::Utils::OpenPersistent(p))); 6411 return UniqueId(reinterpret_cast<uintptr_t>(*v8::Utils::OpenPersistent(p)));
(...skipping 663 matching lines...) Expand 10 before | Expand all | Expand 10 after
7075 double deadline = heap->MonotonicallyIncreasingTimeInMs() + 1; 7075 double deadline = heap->MonotonicallyIncreasingTimeInMs() + 1;
7076 marking->AdvanceIncrementalMarking( 7076 marking->AdvanceIncrementalMarking(
7077 deadline, IncrementalMarking::GC_VIA_STACK_GUARD, 7077 deadline, IncrementalMarking::GC_VIA_STACK_GUARD,
7078 IncrementalMarking::FORCE_COMPLETION, StepOrigin::kV8); 7078 IncrementalMarking::FORCE_COMPLETION, StepOrigin::kV8);
7079 } 7079 }
7080 DCHECK(marking->IsStopped()); 7080 DCHECK(marking->IsStopped());
7081 } 7081 }
7082 7082
7083 } // namespace internal 7083 } // namespace internal
7084 } // namespace v8 7084 } // namespace v8
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698