Store SharedFunctionInfos of a Script in a FixedArray indexed by their ID

test/cctest/test-serialize.cc

 // Copyright 2007-2010 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 1788 matching lines @@
         v8::ScriptCompiler::CompileUnboundScript(
             isolate2, &source, v8::ScriptCompiler::kConsumeCodeCache)
             .ToLocalChecked();
 
     CHECK(!cache->rejected);
 
     Isolate* i_isolate = reinterpret_cast<Isolate*>(isolate2);
     HandleScope i_scope(i_isolate);
     Handle<SharedFunctionInfo> toplevel = v8::Utils::OpenHandle(*unbound);
     Handle<Script> script(Script::cast(toplevel->script()));
-    WeakFixedArray::Iterator iterator(script->shared_function_infos());
     // Every function has been pre-compiled from the code cache.
     int count = 0;
-    while (SharedFunctionInfo* shared = iterator.Next<SharedFunctionInfo>()) {
+    for (int index = 0; index < script->shared_function_infos()->length();
+         ++index) {
+      Object* raw = script->shared_function_infos()->get(index);
+      if (raw->IsSmi()) continue;
+      SharedFunctionInfo* shared =
+          SharedFunctionInfo::cast(WeakCell::cast(raw)->value());
       CHECK(shared->is_compiled());
       CHECK_EQ(Code::kPreAgedCodeAge, shared->code()->GetAge());
       count++;
     }
     CHECK_EQ(3, count);
   }
   isolate2->Dispose();
 }
 
 TEST(Regress503552) {
@@ skipping 478 matching lines @@
   }
   delete[] blob.data;
 }
 
 TEST(SerializationMemoryStats) {
   FLAG_profile_deserialization = true;
   FLAG_always_opt = false;
   v8::StartupData blob = v8::V8::CreateSnapshotDataBlob();
   delete[] blob.data;
 }