Store SharedFunctionInfos of a Script in a FixedArray indexed by their ID

src/parsing/parser.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/parsing/parser.h"
 
 #include <memory>
 
 #include "src/api.h"
 #include "src/ast/ast-expression-rewriter.h"
@@ skipping 802 matching lines @@
 
     if (ok) {
       RewriteDestructuringAssignments();
       int parameter_count = parsing_module_ ? 1 : 0;
       result = factory()->NewScriptOrEvalFunctionLiteral(
           scope, body, function_state.materialized_literal_count(),
           function_state.expected_property_count(), parameter_count);
     }
   }
 
+  info->set_max_function_literal_id(GetLastFunctionLiteralId());

[Toon Verwaest, 2016/12/06 21:10:14]

Mmh. ParseInfo isn't exactly supposed to be a communication channel outerwards
right? What about putting it on the ScriptScope or so after ParseProgram? Isn't
that the only place where we need it? We probably need to make ScriptScope its
own subclass of Scope in that case. (It's not currently if I'm not mistaken)

[jochen (gone - plz use gerrit), 2016/12/07 15:57:00]

it's also what communicates the parsing result to the outside (and the language
mode)

[Toon Verwaest, 2016/12/08 07:31:30]

Oh ok.. buh. Follow-up cleanup then I guess...
Language mode should also just be read from the scope.

+
   // Make sure the target stack is empty.
   DCHECK(target_stack_ == NULL);
 
   return result;
 }
 
 FunctionLiteral* Parser::ParseFunction(Isolate* isolate, ParseInfo* info) {
   // It's OK to use the Isolate & counters here, since this function is only
   // called in the main thread.
   DCHECK(parsing_on_main_thread_);
@@ skipping 4642 matching lines @@
 
   return final_loop;
 }
 
 #undef CHECK_OK
 #undef CHECK_OK_VOID
 #undef CHECK_FAILED
 
 }  // namespace internal
 }  // namespace v8