Store SharedFunctionInfos of a Script in a FixedArray indexed by their ID

src/debug/liveedit.js

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // LiveEdit feature implementation. The script should be executed after
 // debug.js.
 
 // A LiveEdit namespace. It contains functions that modifies JavaScript code
 // according to changes of script source (if possible).
 //
@@ skipping 12 matching lines @@
 (function(global, utils) {
   "use strict";
 
   // -------------------------------------------------------------------
   // Imports
 
   var FindScriptSourcePosition = global.Debug.findScriptSourcePosition;
   var GetScriptBreakPoints;
   var GlobalArray = global.Array;
   var MathFloor = global.Math.floor;
+  var MathMax = global.Math.max;
   var SyntaxError = global.SyntaxError;
 
   utils.Import(function(from) {
     GetScriptBreakPoints = from.GetScriptBreakPoints;
   });
 
   // -------------------------------------------------------------------
 
   // Forward declaration for minifier.
   var FunctionStatus;
@@ skipping 30 matching lines @@
       if (e instanceof SyntaxError) {
         var details = {
           type: "liveedit_compile_error",
           syntaxErrorMessage: e.message
         };
         CopyErrorPositionToDetails(e, details);
         failure.details = details;
       }
       throw failure;
     }
+
+    var max_function_literal_id =
+        MathMax.apply(null, new_compile_info.map(i => i.function_literal_id));

[jochen (gone - plz use gerrit), 2016/12/01 10:30:56]

https://bugs.chromium.org/p/v8/issues/detail?id=5703 for why I'm not using the
spread operator here

+
     var root_new_node = BuildCodeInfoTree(new_compile_info);
 
     // Link recompiled script data with other data.
     FindCorrespondingFunctions(root_old_node, root_new_node);
 
     // Prepare to-do lists.
     var replace_code_list = new GlobalArray();
     var link_to_old_script_list = new GlobalArray();
     var link_to_original_script_list = new GlobalArray();
     var update_positions_list = new GlobalArray();
@@ skipping 79 matching lines @@
 
     // Start with breakpoints. Convert their line/column positions and
     // temporary remove.
     var break_points_restorer = TemporaryRemoveBreakPoints(script, change_log);
 
     var old_script;
 
     // Create an old script only if there are function that should be linked
     // to old version.
     if (link_to_old_script_list.length == 0) {
-      %LiveEditReplaceScript(script, new_source, null);
+      %LiveEditReplaceScript(script, max_function_literal_id, new_source, null);
       old_script = UNDEFINED;
     } else {
       var old_script_name = CreateNameForOldScript(script);
 
       // Update the script text and create a new script representing an old
       // version of the script.
-      old_script = %LiveEditReplaceScript(script, new_source,
-          old_script_name);
+      old_script = %LiveEditReplaceScript(script, max_function_literal_id,
+          new_source, old_script_name);
 
       var link_to_old_script_report = new GlobalArray();
       change_log.push( { linked_to_old_script: link_to_old_script_report } );
 
       // We need to link to old script all former nested functions.
       for (var i = 0; i < link_to_old_script_list.length; i++) {
         LinkToOldScript(link_to_old_script_list[i], old_script,
             link_to_old_script_report);
       }
 
@@ skipping 637 matching lines @@
   // An object describing function compilation details. Its index fields
   // apply to indexes inside array that stores these objects.
   function FunctionCompileInfo(raw_array) {
     this.function_name = raw_array[0];
     this.start_position = raw_array[1];
     this.end_position = raw_array[2];
     this.param_num = raw_array[3];
     this.scope_info = raw_array[4];
     this.outer_index = raw_array[5];
     this.shared_function_info = raw_array[6];
+    this.function_literal_id = raw_array[8];
     this.next_sibling_index = null;
     this.raw_array = raw_array;
   }
 
   function SharedInfoWrapper(raw_array) {
     this.function_name = raw_array[0];
     this.start_position = raw_array[1];
     this.end_position = raw_array[2];
     this.info = raw_array[3];
     this.raw_array = raw_array;
@@ skipping 257 matching lines @@
 
   LiveEdit.TestApi = {
     PosTranslator: PosTranslator,
     CompareStrings: CompareStrings,
     ApplySingleChunkPatch: ApplySingleChunkPatch
   };
 
   global.Debug.LiveEdit = LiveEdit;
 
 })