Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2547413002: ShapeDetection: add UseCounter entry for detect() methods (Closed)

Created:
4 years ago by mcasas
Modified:
4 years ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ShapeDetection: add UseCounter entry for detect() methods After paulkinlan@ publicised this work [1,2] , it's starting to be used, so why not count it? This CL adds UseCounters for those. BUG=665150 [1] https://youtu.be/YJwrBbze_Ec?t=2083 [2] https://twitter.com/Paul_Kinlan/status/805148732652220416 Committed: https://crrev.com/b91ca356ac26a2608c80d738221cfc1b911ac55f Cr-Commit-Position: refs/heads/master@{#436239}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/shapedetection/FaceDetector.idl View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
mcasas
haraken@ PTAL (tiny CL).
4 years ago (2016-12-05 05:04:11 UTC) #5
haraken
LGTM
4 years ago (2016-12-05 05:17:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2547413002/1
4 years ago (2016-12-05 07:27:23 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-05 07:31:47 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-05 07:33:49 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b91ca356ac26a2608c80d738221cfc1b911ac55f
Cr-Commit-Position: refs/heads/master@{#436239}

Powered by Google App Engine
This is Rietveld 408576698