Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2547403002: Added support for isInherited flags to ComputedStyleBase (Closed)

Created:
4 years ago by sashab
Modified:
4 years ago
Reviewers:
meade_UTC10, napper
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added support for isInherited flags to ComputedStyleBase Added support for isInherited flags to ComputedStyleBase, and moved visibilityIsInherited to ComputedStyleBase. This involved adding additional code to generate the new inherited flag fields, as well as adding a version of propagateIndependentInheritedProperties() to ComputedStyleBase. Visibility was already a generated field, but the inherited flag of its generation was not yet being generated in ComputedStyleBase, so this patch moves that field to be generated as well. BUG=628043 Committed: https://crrev.com/3dd00af7d6f27106b11f718190331d290a9f9240 Cr-Commit-Position: refs/heads/master@{#436527}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Review feedback #

Messages

Total messages: 14 (6 generated)
sashab
If you don't understand any part of it please ask :) I was going to ...
4 years ago (2016-12-05 04:36:42 UTC) #2
napper
lgtm
4 years ago (2016-12-05 05:08:00 UTC) #3
sashab
Eddy please review :)
4 years ago (2016-12-06 00:05:37 UTC) #5
meade_UTC10
lgtm This is looking really nice, I'd just like to see a little more commenting ...
4 years ago (2016-12-06 00:15:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2547403002/20001
4 years ago (2016-12-06 02:19:17 UTC) #9
sashab
https://codereview.chromium.org/2547403002/diff/1/third_party/WebKit/Source/build/scripts/make_computed_style_base.py File third_party/WebKit/Source/build/scripts/make_computed_style_base.py (right): https://codereview.chromium.org/2547403002/diff/1/third_party/WebKit/Source/build/scripts/make_computed_style_base.py#newcode105 third_party/WebKit/Source/build/scripts/make_computed_style_base.py:105: is_inherited_method_name=property_name_lower + 'IsInherited', On 2016/12/06 at 00:15:35, Eddy wrote: ...
4 years ago (2016-12-06 02:45:16 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-06 04:38:16 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-06 04:41:48 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3dd00af7d6f27106b11f718190331d290a9f9240
Cr-Commit-Position: refs/heads/master@{#436527}

Powered by Google App Engine
This is Rietveld 408576698