Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2547333002: Replace unique_ptr::reset() to std::move() (Closed)

Created:
4 years ago by skeksk91
Modified:
4 years ago
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace unique_ptr::reset() to std::move() BUG=644626 Committed: https://crrev.com/19e46f29dc94984c71fcaa05babdf14dd252054d Cr-Commit-Position: refs/heads/master@{#436213}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gl/gl_surface_egl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
skeksk91
Hello, kbr! Could you review this commit? This is my first commit. I want to ...
4 years ago (2016-12-04 09:35:50 UTC) #2
Ken Russell (switch to Gerrit)
Thanks, looks fine. LGTM
4 years ago (2016-12-04 23:58:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2547333002/1
4 years ago (2016-12-04 23:58:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-05 01:45:07 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-05 01:47:04 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/19e46f29dc94984c71fcaa05babdf14dd252054d
Cr-Commit-Position: refs/heads/master@{#436213}

Powered by Google App Engine
This is Rietveld 408576698