Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2547273002: Lazy load lock_screen.html in options. (Closed)

Created:
4 years ago by jdufault
Modified:
4 years ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Lazy load lock_screen.html in options. Locally, this brings first paint time from 1000ms to 500ms. BUG=670914 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -3 lines) Patch
M chrome/browser/resources/options/chromeos/quick_unlock_configure_overlay.js View 2 chunks +35 lines, -0 lines 1 comment Download
M chrome/browser/resources/options/options.html View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (7 generated)
jdufault
dbeam@, xiaoyinh@, PTAL. Thanks!
4 years ago (2016-12-03 01:16:14 UTC) #6
Dan Beam
https://codereview.chromium.org/2547273002/diff/1/chrome/browser/resources/options/chromeos/quick_unlock_configure_overlay.js File chrome/browser/resources/options/chromeos/quick_unlock_configure_overlay.js (right): https://codereview.chromium.org/2547273002/diff/1/chrome/browser/resources/options/chromeos/quick_unlock_configure_overlay.js#newcode59 chrome/browser/resources/options/chromeos/quick_unlock_configure_overlay.js:59: this.lazyLoadPolymer_(); i don't think we should load polymer until ...
4 years ago (2016-12-03 02:05:06 UTC) #9
jdufault
4 years ago (2016-12-03 02:12:28 UTC) #10
Message was sent while issue was closed.
Closing in favor of https://codereview.chromium.org/2529293015/

Powered by Google App Engine
This is Rietveld 408576698