Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: content/browser/compositor/mus_browser_compositor_output_surface.cc

Issue 2547243002: Set device scale factor in CompositorFrame and scale frame size in WS. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/compositor/mus_browser_compositor_output_surface.h" 5 #include "content/browser/compositor/mus_browser_compositor_output_surface.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "cc/output/compositor_frame.h" 9 #include "cc/output/compositor_frame.h"
10 #include "cc/output/output_surface_frame.h" 10 #include "cc/output/output_surface_frame.h"
(...skipping 11 matching lines...) Expand all
22 22
23 namespace content { 23 namespace content {
24 24
25 MusBrowserCompositorOutputSurface::MusBrowserCompositorOutputSurface( 25 MusBrowserCompositorOutputSurface::MusBrowserCompositorOutputSurface(
26 ui::Window* window, 26 ui::Window* window,
27 scoped_refptr<ContextProviderCommandBuffer> context, 27 scoped_refptr<ContextProviderCommandBuffer> context,
28 gpu::GpuMemoryBufferManager* gpu_memory_buffer_manager, 28 gpu::GpuMemoryBufferManager* gpu_memory_buffer_manager,
29 scoped_refptr<ui::CompositorVSyncManager> vsync_manager, 29 scoped_refptr<ui::CompositorVSyncManager> vsync_manager,
30 cc::SyntheticBeginFrameSource* begin_frame_source, 30 cc::SyntheticBeginFrameSource* begin_frame_source,
31 std::unique_ptr<display_compositor::CompositorOverlayCandidateValidator> 31 std::unique_ptr<display_compositor::CompositorOverlayCandidateValidator>
32 overlay_candidate_validator) 32 overlay_candidate_validator,
33 float device_scale_factor)
33 : GpuBrowserCompositorOutputSurface(std::move(context), 34 : GpuBrowserCompositorOutputSurface(std::move(context),
34 std::move(vsync_manager), 35 std::move(vsync_manager),
35 begin_frame_source, 36 begin_frame_source,
36 std::move(overlay_candidate_validator)), 37 std::move(overlay_candidate_validator)),
37 ui_window_(window) { 38 ui_window_(window),
39 device_scale_factor_(device_scale_factor) {
38 ui_compositor_frame_sink_ = ui_window_->RequestCompositorFrameSink( 40 ui_compositor_frame_sink_ = ui_window_->RequestCompositorFrameSink(
39 ui::mojom::CompositorFrameSinkType::DEFAULT, context, 41 ui::mojom::CompositorFrameSinkType::DEFAULT, context,
40 gpu_memory_buffer_manager); 42 gpu_memory_buffer_manager);
41 ui_compositor_frame_sink_->BindToClient(this); 43 ui_compositor_frame_sink_->BindToClient(this);
42 } 44 }
43 45
44 MusBrowserCompositorOutputSurface::MusBrowserCompositorOutputSurface( 46 MusBrowserCompositorOutputSurface::MusBrowserCompositorOutputSurface(
45 aura::Window* window, 47 aura::Window* window,
46 scoped_refptr<ContextProviderCommandBuffer> context, 48 scoped_refptr<ContextProviderCommandBuffer> context,
47 gpu::GpuMemoryBufferManager* gpu_memory_buffer_manager, 49 gpu::GpuMemoryBufferManager* gpu_memory_buffer_manager,
48 scoped_refptr<ui::CompositorVSyncManager> vsync_manager, 50 scoped_refptr<ui::CompositorVSyncManager> vsync_manager,
49 cc::SyntheticBeginFrameSource* begin_frame_source, 51 cc::SyntheticBeginFrameSource* begin_frame_source,
50 std::unique_ptr<display_compositor::CompositorOverlayCandidateValidator> 52 std::unique_ptr<display_compositor::CompositorOverlayCandidateValidator>
51 overlay_candidate_validator) 53 overlay_candidate_validator,
54 float device_scale_factor)
52 : GpuBrowserCompositorOutputSurface(std::move(context), 55 : GpuBrowserCompositorOutputSurface(std::move(context),
53 std::move(vsync_manager), 56 std::move(vsync_manager),
54 begin_frame_source, 57 begin_frame_source,
55 std::move(overlay_candidate_validator)), 58 std::move(overlay_candidate_validator)),
56 window_(window) { 59 window_(window),
60 device_scale_factor_(device_scale_factor) {
57 aura::WindowPortMus* window_port = aura::WindowPortMus::Get(window_); 61 aura::WindowPortMus* window_port = aura::WindowPortMus::Get(window_);
58 DCHECK(window_port); 62 DCHECK(window_port);
59 compositor_frame_sink_ = window_port->RequestCompositorFrameSink( 63 compositor_frame_sink_ = window_port->RequestCompositorFrameSink(
60 ui::mojom::CompositorFrameSinkType::DEFAULT, context, 64 ui::mojom::CompositorFrameSinkType::DEFAULT, context,
61 gpu_memory_buffer_manager); 65 gpu_memory_buffer_manager);
62 compositor_frame_sink_->BindToClient(this); 66 compositor_frame_sink_->BindToClient(this);
63 } 67 }
64 68
65 MusBrowserCompositorOutputSurface::~MusBrowserCompositorOutputSurface() {} 69 MusBrowserCompositorOutputSurface::~MusBrowserCompositorOutputSurface() {}
66 70
67 void MusBrowserCompositorOutputSurface::SwapBuffers( 71 void MusBrowserCompositorOutputSurface::SwapBuffers(
68 cc::OutputSurfaceFrame frame) { 72 cc::OutputSurfaceFrame frame) {
69 const gfx::Rect bounds = ui_window_ ? gfx::Rect(ui_window_->bounds().size()) 73 const gfx::Rect bounds = ui_window_ ? gfx::Rect(ui_window_->bounds().size())
70 : gfx::Rect(window_->bounds().size()); 74 : gfx::Rect(window_->bounds().size());
71 cc::CompositorFrame ui_frame; 75 cc::CompositorFrame ui_frame;
76 ui_frame.metadata.device_scale_factor = device_scale_factor_;
danakj 2016/12/06 22:44:27 What if the device scale changes? It's not fixed f
riajiang 2016/12/15 18:14:41 Changed to get the device_scale_factor from the di
72 ui_frame.metadata.latency_info = std::move(frame.latency_info); 77 ui_frame.metadata.latency_info = std::move(frame.latency_info);
73 // Reset latency_info to known empty state after moving contents. 78 // Reset latency_info to known empty state after moving contents.
74 frame.latency_info.clear(); 79 frame.latency_info.clear();
75 const cc::RenderPassId render_pass_id(1, 1); 80 const cc::RenderPassId render_pass_id(1, 1);
76 std::unique_ptr<cc::RenderPass> pass = cc::RenderPass::Create(); 81 std::unique_ptr<cc::RenderPass> pass = cc::RenderPass::Create();
77 const bool has_transparent_background = true; 82 const bool has_transparent_background = true;
78 pass->SetAll(render_pass_id, bounds, bounds, gfx::Transform(), 83 pass->SetAll(render_pass_id, bounds, bounds, gfx::Transform(),
79 has_transparent_background); 84 has_transparent_background);
80 // The SharedQuadState is owned by the SharedQuadStateList 85 // The SharedQuadState is owned by the SharedQuadStateList
81 // shared_quad_state_list. 86 // shared_quad_state_list.
(...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after
200 205
201 const gpu::Mailbox& MusBrowserCompositorOutputSurface::GetMailboxFromResourceId( 206 const gpu::Mailbox& MusBrowserCompositorOutputSurface::GetMailboxFromResourceId(
202 uint32_t id) { 207 uint32_t id) {
203 DCHECK_LT(id, mailboxes_.size()); 208 DCHECK_LT(id, mailboxes_.size());
204 DCHECK(std::find(free_resource_ids_.begin(), free_resource_ids_.end(), id) == 209 DCHECK(std::find(free_resource_ids_.begin(), free_resource_ids_.end(), id) ==
205 free_resource_ids_.end()); 210 free_resource_ids_.end());
206 return mailboxes_[id]; 211 return mailboxes_[id];
207 } 212 }
208 213
209 } // namespace content 214 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698