Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1440)

Unified Diff: net/quic/platform/api/quic_clock.h

Issue 2547233002: Add a QuicChromiumClock and make QuicClock abstract to match internal code. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/platform/api/quic_clock.h
diff --git a/net/quic/platform/api/quic_clock.h b/net/quic/platform/api/quic_clock.h
index 7f2518df4357ab2b2ba7a0ca059fbd66c2a0577f..2931562716a542010dc9afe56bc9431a5bd05c19 100644
--- a/net/quic/platform/api/quic_clock.h
+++ b/net/quic/platform/api/quic_clock.h
@@ -5,38 +5,34 @@
#ifndef NET_QUIC_PLATFORM_API_QUIC_CLOCK_H_
#define NET_QUIC_PLATFORM_API_QUIC_CLOCK_H_
-#include "base/macros.h"
#include "net/base/net_export.h"
#include "net/quic/core/quic_time.h"
namespace net {
-typedef double WallTime;
-
-// Clock to efficiently retrieve an approximately accurate time from an
-// EpollServer.
+// Interface for retreiving the current time.
class NET_EXPORT_PRIVATE QuicClock {
public:
QuicClock();
virtual ~QuicClock();
+ QuicClock(const QuicClock&) = delete;
+ QuicClock& operator=(const QuicClock&) = delete;
+
// Returns the approximate current time as a QuicTime object.
Jana 2016/12/03 19:32:19 Can you also define more precisely what "approxima
- virtual QuicTime ApproximateNow() const;
+ virtual QuicTime ApproximateNow() const = 0;
// Returns the current time as a QuicTime object.
// Note: this use significant resources please use only if needed.
Jana 2016/12/03 19:32:19 This note should probably say "this may use signif
- virtual QuicTime Now() const;
+ virtual QuicTime Now() const = 0;
// WallNow returns the current wall-time - a time that is consistent across
// different clocks.
- virtual QuicWallTime WallNow() const;
+ virtual QuicWallTime WallNow() const = 0;
// Converts |walltime| to a QuicTime relative to this clock's epoch.
virtual QuicTime ConvertWallTimeToQuicTime(
const QuicWallTime& walltime) const;
-
- private:
- DISALLOW_COPY_AND_ASSIGN(QuicClock);
};
} // namespace net

Powered by Google App Engine
This is Rietveld 408576698