Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Unified Diff: runtime/vm/raw_object.h

Issue 254723003: Remember all deopt reasons in ic_data, not just the last one. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object_test.cc ('k') | runtime/vm/stack_frame.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/raw_object.h
===================================================================
--- runtime/vm/raw_object.h (revision 35455)
+++ runtime/vm/raw_object.h (working copy)
@@ -1021,19 +1021,18 @@
RAW_HEAP_OBJECT_IMPLEMENTATION(ICData);
RawObject** from() {
- return reinterpret_cast<RawObject**>(&ptr()->function_);
+ return reinterpret_cast<RawObject**>(&ptr()->owner_);
}
- RawFunction* function_; // Parent/calling function of this IC.
+ RawFunction* owner_; // Parent/calling function of this IC.
RawString* target_name_; // Name of target function.
RawArray* args_descriptor_; // Arguments descriptor.
RawArray* ic_data_; // Contains class-ids, target and count.
RawObject** to() {
return reinterpret_cast<RawObject**>(&ptr()->ic_data_);
}
- intptr_t deopt_id_; // Deoptimization id corresponding to this IC.
- intptr_t num_args_tested_; // Number of arguments tested in IC.
- uint8_t deopt_reason_; // Last deoptimization reason.
- uint8_t is_closure_call_; // 0 or 1.
+ int32_t deopt_id_; // Deoptimization id corresponding to this IC.
+ uint32_t state_bits_; // Number of arguments tested in IC, deopt reasons,
+ // is closure call, JS warning issued.
};
« no previous file with comments | « runtime/vm/object_test.cc ('k') | runtime/vm/stack_frame.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698