runtime/vm/compiler.cc - Issue 254723003: Remember all deopt reasons in ic_data, not just the last one.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/compiler.cc

Issue 254723003: Remember all deopt reasons in ic_data, not just the last one. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/compiler.cc

===================================================================

--- runtime/vm/compiler.cc (revision 35455)

+++ runtime/vm/compiler.cc (working copy)

@@ -659,11 +659,14 @@

Smi& reason = Smi::Handle();

for (intptr_t i = 0; i < deopt_table_length; ++i) {

DeoptTable::GetEntry(deopt_table, i, &offset, &info, &reason);

+ ASSERT((0 <= reason.Value()) &&

+ (reason.Value() < ICData::kDeoptNumReasons));

OS::Print("%4" Pd ": 0x%" Px " %s (%s)\n",

start + offset.Value(),

info.ToCString(),

- DeoptReasonToText(reason.Value()));

+ DeoptReasonToCString(

+ static_cast<ICData::DeoptReasonId>(reason.Value())));

}

OS::Print("}\n");

}

« no previous file with comments | « runtime/vm/code_patcher_x64_test.cc ('k') | runtime/vm/deopt_instructions.h » ('j') | no next file with comments »