Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: runtime/vm/code_descriptors.h

Issue 254723003: Remember all deopt reasons in ic_data, not just the last one. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/code_generator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/code_descriptors.h
===================================================================
--- runtime/vm/code_descriptors.h (revision 35455)
+++ runtime/vm/code_descriptors.h (working copy)
@@ -19,13 +19,14 @@
intptr_t pc_offset; // PC offset value of the descriptor.
PcDescriptors::Kind kind; // Descriptor kind (kDeopt, kOther).
intptr_t deopt_id; // Deoptimization id.
- intptr_t data; // Token position or deopt rason.
+ intptr_t data; // Token position or deopt reason.
intptr_t try_index; // Try block index of PC or deopt array index.
void SetTokenPos(intptr_t value) { data = value; }
intptr_t TokenPos() const { return data; }
- void SetDeoptReason(DeoptReasonId value) { data = value; }
- DeoptReasonId DeoptReason() const {
- return static_cast<DeoptReasonId>(data);
+ void SetDeoptReason(ICData::DeoptReasonId value) { data = value; }
+ ICData::DeoptReasonId DeoptReason() const {
+ ASSERT((0 <= data) && (data < ICData::ICData::kDeoptNumReasons));
+ return static_cast<ICData::DeoptReasonId>(data);
}
};
@@ -49,7 +50,7 @@
intptr_t TokenPos(intptr_t index) const {
return list_[index].TokenPos();
}
- DeoptReasonId DeoptReason(intptr_t index) const {
+ ICData::DeoptReasonId DeoptReason(intptr_t index) const {
return list_[index].DeoptReason();
}
intptr_t TryIndex(intptr_t index) const {
« no previous file with comments | « no previous file | runtime/vm/code_generator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698