Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1044)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py

Issue 2547153002: In webkit-patch rebaseline-cl, abort if results are missing. (Closed)
Patch Set: Remove exception; use return value of None to indicate missing results. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py
index 874130a836f0a391d026b6ac2677c7fde5e2c569..aad4349e13c41c0fe4d52eaa98fbc0cae41cb018 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py
@@ -51,8 +51,8 @@ class RebaselineCLTest(BaseTestCase, LoggingTestCase):
"is_try_builder": True,
},
"MOCK Try Linux": {
- "port_name": "test-mac-mac10.10",
- "specifiers": ["Mac10.10", "Release"],
+ "port_name": "test-linux-trusty",
+ "specifiers": ["Trusty", "Release"],
"is_try_builder": True,
},
})
@@ -237,3 +237,13 @@ class RebaselineCLTest(BaseTestCase, LoggingTestCase):
'INFO: Triggering try jobs for:\n',
'INFO: MOCK Try Win\n',
])
+
+ def test_bails_when_one_build_is_missing_results(self):
+ self.tool.buildbot.set_results(Build("MOCK Try Win", 5000), None)
+ self.command.execute(self.command_options(issue=11112222), [], self.tool)
+ self.assertLog([
+ 'ERROR: Failed to fetch results from '
+ '"https://storage.googleapis.com/chromium-layout-test-archives/MOCK_Try_Win/5000/layout-test-results".\n'
+ 'Try starting a new job for MOCK Try Win by running :\n'
+ ' git cl try -b MOCK Try Win\n'
+ ])
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698