third_party/WebKit/Source/modules/presentation/PresentationConnectionCallbacks.cpp - Issue 2547143002: [Presentation API] fire onconnectionavailable and onconnect event asynchronously

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/presentation/PresentationConnectionCallbacks.cpp

Issue 2547143002: [Presentation API] fire onconnectionavailable and onconnect event asynchronously (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp ('k') | third_party/WebKit/Source/modules/presentation/PresentationRequest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/presentation/PresentationConnectionCallbacks.cpp

diff --git a/third_party/WebKit/Source/modules/presentation/PresentationConnectionCallbacks.cpp b/third_party/WebKit/Source/modules/presentation/PresentationConnectionCallbacks.cpp

index 6573873469e4dca7afa338204832a0b865f478d8..fa6fc9634203985cf1fedf16c915d53c4534f7b6 100644

--- a/third_party/WebKit/Source/modules/presentation/PresentationConnectionCallbacks.cpp

+++ b/third_party/WebKit/Source/modules/presentation/PresentationConnectionCallbacks.cpp

@@ -6,7 +6,9 @@

#include "bindings/core/v8/ScriptPromiseResolver.h"

#include "core/dom/DOMException.h"

+#include "core/dom/ExecutionContextTask.h"

#include "modules/presentation/PresentationConnection.h"

+#include "modules/presentation/PresentationConnectionAvailableEvent.h"

#include "modules/presentation/PresentationError.h"

#include "modules/presentation/PresentationRequest.h"

#include "public/platform/modules/presentation/WebPresentationConnectionClient.h"

@@ -33,8 +35,16 @@ void PresentationConnectionCallbacks::onSuccess(

if (!m_resolver->getExecutionContext() ||

m_resolver->getExecutionContext()->activeDOMObjectsAreStopped())

return;

- m_resolver->resolve(PresentationConnection::take(

- m_resolver.get(), std::move(result), m_request));

+ auto* connection = PresentationConnection::take(m_resolver.get(),

+ std::move(result), m_request);

+ m_resolver->resolve(connection);

+ m_resolver->getExecutionContext()->postTask(

+ BLINK_FROM_HERE,

+ createSameThreadTask(

+ &PresentationRequest::dispatchConnectionAvailableEvent, m_request,

+ wrapPersistent(connection)));

mlamouri (slow - plz ping) 2016/12/05 13:39:10 Any reason I'm missing why this is not in the ::ta

}

void PresentationConnectionCallbacks::onError(