DescriptionRevert of [Android] ForeignSessionHelper string memory leak fix. (https://codereview.chromium.org/257513007/)
Reason for revert:
The CQ seems to have ignored the trybot failures on `android_dbg_triggered_tests`. Step `unit_tests` failing since http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/13319
Failures on GCMServiceTest.* and ZipTest.ZipTimeStamp. Suspecting this CL.
Original issue's description:
> [Android] Delete local java reference every loop.
>
> In ForeignSessionHelper class, there were two places
> we allocate ScopedJavaLocalRef<jstring> inside a loop and
> doesn't delete. The Java local references are cleaned upon
> returning to Java, but there is 512 local reference hard-limit
> so we should delete it every loop to avoid hitting the limit.
>
> BUG=366659
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266398
TBR=feng@chromium.org,newt@chromium.org,kkimlabs@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=366659
Patch Set 1 #
Created: 6 years, 7 months ago
(Patch set is too large to download)
Messages
Total messages: 6 (0 generated)
|