Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 254713007: Revert of [Android] ForeignSessionHelper string memory leak fix. (Closed)

Created:
6 years, 7 months ago by tapted
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of [Android] ForeignSessionHelper string memory leak fix. (https://codereview.chromium.org/257513007/) Reason for revert: The CQ seems to have ignored the trybot failures on `android_dbg_triggered_tests`. Step `unit_tests` failing since http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/13319 Failures on GCMServiceTest.* and ZipTest.ZipTimeStamp. Suspecting this CL. Original issue's description: > [Android] Delete local java reference every loop. > > In ForeignSessionHelper class, there were two places > we allocate ScopedJavaLocalRef<jstring> inside a loop and > doesn't delete. The Java local references are cleaned upon > returning to Java, but there is 512 local reference hard-limit > so we should delete it every loop to avoid hitting the limit. > > BUG=366659 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266398 TBR=feng@chromium.org,newt@chromium.org,kkimlabs@chromium.org NOTREECHECKS=true NOTRY=true BUG=366659

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/browser/android/foreign_session_helper.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tapted
Created Revert of [Android] ForeignSessionHelper string memory leak fix.
6 years, 7 months ago (2014-04-28 01:04:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/254713007/1
6 years, 7 months ago (2014-04-28 01:05:11 UTC) #2
tapted
The CQ bit was unchecked by tapted@chromium.org
6 years, 7 months ago (2014-04-28 01:05:43 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 01:06:11 UTC) #4
tapted
On 2014/04/28 01:05:43, tapted wrote: > The CQ bit was unchecked by mailto:tapted@chromium.org hmm GCMServiceTest.SignOutAndThenSignIn ...
6 years, 7 months ago (2014-04-28 01:12:19 UTC) #5
tapted
6 years, 7 months ago (2014-04-28 02:55:15 UTC) #6
Message was sent while issue was closed.
Update: filed bug http://crbug.com/367600

Closing this CL

Powered by Google App Engine
This is Rietveld 408576698