Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Issue 254713004: Reenable WebrtcBrowserTest.CanMakeEmptyCallThenAddStreamsAndRenegotiateEnable test again. (Closed)

Created:
6 years, 8 months ago by perkj_chrome
Modified:
6 years, 3 months ago
Reviewers:
phoglund_chromium
CC:
chromium-reviews, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Reenable WebrtcBrowserTest.CanMakeEmptyCallThenAddStreamsAndRenegotiateEnable test again. The underalying problem is now fixed. See http://crbug/293125 and https://code.google.com/p/webrtc/source/detail?r=5870 BUG=293125, 362431 Committed: https://crrev.com/78863085838f2ff9e47a680d9c762b133abde544 Cr-Commit-Position: refs/heads/master@{#291648}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M content/browser/media/webrtc_browsertest.cc View 1 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
perkj_chrome
6 years, 8 months ago (2014-04-25 07:58:54 UTC) #1
phoglund_chromium
lgtm
6 years, 8 months ago (2014-04-25 09:08:42 UTC) #2
perkj_chrome
The CQ bit was checked by perkj@chromium.org
6 years, 8 months ago (2014-04-25 14:24:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/perkj@chromium.org/254713004/1
6 years, 8 months ago (2014-04-25 22:17:42 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-26 04:04:48 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_rel
6 years, 8 months ago (2014-04-26 04:04:49 UTC) #6
phoglund_chromium
un-ccing until this comes back to life.
6 years, 4 months ago (2014-08-18 07:04:26 UTC) #7
perkj_chrome
Retrying since 362431 is marked as fixed.
6 years, 4 months ago (2014-08-25 06:58:58 UTC) #8
perkj_chrome
The CQ bit was checked by perkj@chromium.org
6 years, 4 months ago (2014-08-25 06:59:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/perkj@chromium.org/254713004/20001
6 years, 4 months ago (2014-08-25 06:59:58 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (20001) as b9a00c2caf679dfd2e97a3d6bbfd5e214609e1fc
6 years, 4 months ago (2014-08-25 07:53:24 UTC) #11
Finnur
A revert of this CL (patchset #2) has been created in https://codereview.chromium.org/500033003/ by finnur@chromium.org. The ...
6 years, 4 months ago (2014-08-25 12:01:59 UTC) #12
pauljensen
A revert of this CL (patchset #2) has been created in https://codereview.chromium.org/500963002/ by pauljensen@chromium.org. The ...
6 years, 4 months ago (2014-08-25 12:31:14 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:33:18 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/78863085838f2ff9e47a680d9c762b133abde544
Cr-Commit-Position: refs/heads/master@{#291648}

Powered by Google App Engine
This is Rietveld 408576698