Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Unified Diff: sync/api/attachments/attachment_service_proxy_for_test.h

Issue 254713003: sync: don't require a MessageLoopProxy in AttachmentServiceProxyForTest (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sync/api/attachments/attachment_service_proxy_for_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/api/attachments/attachment_service_proxy_for_test.h
diff --git a/sync/api/attachments/attachment_service_proxy_for_test.h b/sync/api/attachments/attachment_service_proxy_for_test.h
index 916e788d74beba54597f4b6f6a7051505cf35bc5..2fb5c861e6a21a396b2740c2f0ece6cae4781e53 100644
--- a/sync/api/attachments/attachment_service_proxy_for_test.h
+++ b/sync/api/attachments/attachment_service_proxy_for_test.h
@@ -14,8 +14,9 @@ namespace syncer {
// An self-contained AttachmentServiceProxy to reduce boilerplate code in tests.
//
-// Constructs and owns an AttachmentService suitable for use in tests. Assumes
-// the current thread has a MessageLoop.
+// Constructs and owns an AttachmentService suitable for use in tests.
+// NOTE: This class does not require the current thread to have a MessageLoop,
+// however all methods will effectively become no-op stubs in that case.
class SYNC_EXPORT AttachmentServiceProxyForTest
: public AttachmentServiceProxy {
public:
« no previous file with comments | « no previous file | sync/api/attachments/attachment_service_proxy_for_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698