Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2547093002: Revert of Don't expand empty rect during rect mapping (patchset #4 id:60001 of https://codereview.c… (Closed)

Created:
4 years ago by Xianzhu
Modified:
4 years ago
Reviewers:
chrishtr
CC:
chromium-reviews, pdr+renderingwatchlist_chromium.org, shans, rjwright, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-animation_chromium.org, blink-reviews-layout_chromium.org, mac-reviews_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, darktears, blink-reviews, Eric Willigers
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Revert of Don't expand empty rect during rect mapping (patchset #4 id:60001 of https://codereview.chromium.org/2416693002/ ) Reason for revert: It changed transform->mapRect(enclosingIntRect(rect)) to transform->mapRect(FloatRect(enclosingIntRect(rect))) causing missing enclosingIntRect() after the transform. We may also need enclosingIntRect for empty rects because even empty object can have visible filter depending on pixel snapping here. BUG=669774 TEST=paint/invalidation/rotated-subpixel.html Original issue's description: > Don't expand empty rect during rect mapping > > For example, enclosingIntRect(LayoutRect(0.5, 0.5, 0, 0)) results > IntRect(0, 0, 1, 1). This causes unnecessary non-empty visual rects > mapped from empty LayoutRects. > > This CL is mainly to reduce the difference between the old path and > slimmingPaintInvalidation with pixel snapping feature. > > Committed: https://crrev.com/67c516aaed2486295a98d7f0ff2235b921cd7933 > Cr-Commit-Position: refs/heads/master@{#424970} TBR=chrishtr@chromium.org Review-Url: https://codereview.chromium.org/2545573002 Cr-Commit-Position: refs/heads/master@{#435677}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -9 lines) Patch
A third_party/WebKit/LayoutTests/paint/invalidation/rotated-subpixel.html View 1 chunk +17 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/rotated-subpixel-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/rotated-subpixel-expected.txt View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/animated-path-inside-transformed-html-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/transform-inline-layered-child-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/editing/selection/transformed-selection-rects-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/animated-path-inside-transformed-html-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/transform-inline-layered-child-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/editing/selection/transformed-selection-rects-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/animated-path-inside-transformed-html-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/transform-inline-layered-child-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Xianzhu
4 years ago (2016-12-02 19:01:12 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) to pending queue manually as
232175eb6bdfa080b36e59a1a9ed419eef9849b5.

Powered by Google App Engine
This is Rietveld 408576698