Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(852)

Unified Diff: chrome/browser/chromeos/arc/auth/arc_robot_auth_code_fetcher.cc

Issue 2547073002: Fix race issue in ArcAuthService. (Closed)
Patch Set: Address comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/arc/auth/arc_robot_auth_code_fetcher.cc
diff --git a/chrome/browser/chromeos/arc/auth/arc_robot_auth.cc b/chrome/browser/chromeos/arc/auth/arc_robot_auth_code_fetcher.cc
similarity index 85%
rename from chrome/browser/chromeos/arc/auth/arc_robot_auth.cc
rename to chrome/browser/chromeos/arc/auth/arc_robot_auth_code_fetcher.cc
index b8c0a2490cb3d7482a4605a3aa329df6726882ad..58bedb762d2fe7fa2e9128e73a8c2d1cd4209fb6 100644
--- a/chrome/browser/chromeos/arc/auth/arc_robot_auth.cc
+++ b/chrome/browser/chromeos/arc/auth/arc_robot_auth_code_fetcher.cc
@@ -2,7 +2,9 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/browser/chromeos/arc/auth/arc_robot_auth.h"
+#include "chrome/browser/chromeos/arc/auth/arc_robot_auth_code_fetcher.h"
+
+#include <string>
#include "base/bind.h"
#include "chrome/browser/browser_process.h"
@@ -36,11 +38,11 @@ const policy::CloudPolicyClient* GetCloudPolicyClient() {
namespace arc {
-ArcRobotAuth::ArcRobotAuth() : weak_ptr_factory_(this) {}
+ArcRobotAuthCodeFetcher::ArcRobotAuthCodeFetcher() : weak_ptr_factory_(this) {}
-ArcRobotAuth::~ArcRobotAuth() = default;
+ArcRobotAuthCodeFetcher::~ArcRobotAuthCodeFetcher() = default;
-void ArcRobotAuth::FetchRobotAuthCode(const RobotAuthCodeCallback& callback) {
+void ArcRobotAuthCodeFetcher::Fetch(const FetchCallback& callback) {
DCHECK(!fetch_request_job_);
const policy::CloudPolicyClient* client = GetCloudPolicyClient();
@@ -58,12 +60,12 @@ void ArcRobotAuth::FetchRobotAuthCode(const RobotAuthCodeCallback& callback) {
request->add_auth_scope(GaiaConstants::kAnyApiOAuth2Scope);
fetch_request_job_->Start(
- base::Bind(&ArcRobotAuth::OnFetchRobotAuthCodeCompleted,
+ base::Bind(&ArcRobotAuthCodeFetcher::OnFetchRobotAuthCodeCompleted,
weak_ptr_factory_.GetWeakPtr(), callback));
}
-void ArcRobotAuth::OnFetchRobotAuthCodeCompleted(
- RobotAuthCodeCallback callback,
+void ArcRobotAuthCodeFetcher::OnFetchRobotAuthCodeCompleted(
+ FetchCallback callback,
policy::DeviceManagementStatus status,
int net_error,
const enterprise_management::DeviceManagementResponse& response) {

Powered by Google App Engine
This is Rietveld 408576698