Fix race issue in ArcAuthService.

chrome/browser/chromeos/arc/arc_auth_code_fetcher.cc

Index: chrome/browser/chromeos/arc/arc_auth_code_fetcher.cc
diff --git a/chrome/browser/chromeos/arc/arc_auth_code_fetcher.cc b/chrome/browser/chromeos/arc/arc_auth_code_fetcher.cc
deleted file mode 100644
index 54e334f9960550d011577ee046cb8fc61f860356..0000000000000000000000000000000000000000
--- a/chrome/browser/chromeos/arc/arc_auth_code_fetcher.cc
+++ /dev/null
@@ -1,170 +0,0 @@
-// Copyright 2016 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/browser/chromeos/arc/arc_auth_code_fetcher.h"
-
-#include "base/bind.h"
-#include "base/callback_helpers.h"
-#include "base/json/json_string_value_serializer.h"
-#include "base/json/json_writer.h"
-#include "base/logging.h"
-#include "base/values.h"
-#include "chrome/browser/signin/profile_oauth2_token_service_factory.h"
-#include "chrome/browser/signin/signin_manager_factory.h"
-#include "chrome/browser/ui/ash/multi_user/multi_user_util.h"
-#include "components/signin/core/account_id/account_id.h"
-#include "components/signin/core/browser/profile_oauth2_token_service.h"
-#include "components/signin/core/browser/signin_manager_base.h"
-#include "components/user_manager/known_user.h"
-#include "content/public/browser/browser_context.h"
-#include "content/public/common/url_constants.h"
-#include "google_apis/gaia/gaia_auth_fetcher.h"
-#include "google_apis/gaia/gaia_constants.h"
-#include "net/base/load_flags.h"
-#include "net/http/http_status_code.h"
-#include "net/url_request/url_fetcher.h"
-
-namespace arc {
-
-namespace {
-
-constexpr int kGetAuthCodeNetworkRetry = 3;
-
-constexpr char kConsumerName[] = "ArcAuthContext";
-constexpr char kToken[] = "token";
-constexpr char kDeviceId[] = "device_id";
-constexpr char kDeviceType[] = "device_type";
-constexpr char kDeviceTypeArc[] = "arc_plus_plus";
-constexpr char kLoginScopedToken[] = "login_scoped_token";
-constexpr char kGetAuthCodeHeaders[] =
-    "Content-Type: application/json; charset=utf-8";
-constexpr char kContentTypeJSON[] = "application/json";
-constexpr char kEndPoint[] =
-    "https://www.googleapis.com/oauth2/v4/ExchangeToken";
-
-}  // namespace
-
-ArcAuthCodeFetcher::ArcAuthCodeFetcher(Profile* profile,
-                                       ArcAuthContext* context)
-    : OAuth2TokenService::Consumer(kConsumerName),
-      profile_(profile),
-      context_(context),
-      weak_ptr_factory_(this) {}
-
-ArcAuthCodeFetcher::~ArcAuthCodeFetcher() = default;
-
-void ArcAuthCodeFetcher::Fetch(const FetchCallback& callback) {
-  DCHECK(callback_.is_null());
-  callback_ = callback;
-
-  context_->Prepare(base::Bind(&ArcAuthCodeFetcher::OnPrepared,
-                               weak_ptr_factory_.GetWeakPtr()));
-}
-
-void ArcAuthCodeFetcher::OnPrepared(
-    net::URLRequestContextGetter* request_context_getter) {
-  if (!request_context_getter) {
-    base::ResetAndReturn(&callback_).Run(std::string());
-    return;
-  }
-
-  DCHECK(!request_context_getter_);
-  request_context_getter_ = request_context_getter;
-
-  // Get token service and account ID to fetch auth tokens.
-  ProfileOAuth2TokenService* const token_service = context_->token_service();
-  const std::string& account_id = context_->account_id();
-  DCHECK(token_service->RefreshTokenIsAvailable(account_id));
-
-  OAuth2TokenService::ScopeSet scopes;
-  scopes.insert(GaiaConstants::kOAuth1LoginScope);
-  login_token_request_ = token_service->StartRequest(account_id, scopes, this);
-}
-
-void ArcAuthCodeFetcher::OnGetTokenSuccess(
-    const OAuth2TokenService::Request* request,
-    const std::string& access_token,
-    const base::Time& expiration_time) {
-  ResetFetchers();
-
-  const std::string device_id = user_manager::known_user::GetDeviceId(
-      multi_user_util::GetAccountIdFromProfile(profile_));
-  DCHECK(!device_id.empty());
-
-  base::DictionaryValue request_data;
-  request_data.SetString(kLoginScopedToken, access_token);
-  request_data.SetString(kDeviceType, kDeviceTypeArc);
-  request_data.SetString(kDeviceId, device_id);
-  std::string request_string;
-  base::JSONWriter::Write(request_data, &request_string);
-
-  auth_code_fetcher_ =
-      net::URLFetcher::Create(0, GURL(kEndPoint), net::URLFetcher::POST, this);
-  auth_code_fetcher_->SetRequestContext(request_context_getter_);
-  auth_code_fetcher_->SetUploadData(kContentTypeJSON, request_string);
-  auth_code_fetcher_->SetLoadFlags(net::LOAD_DISABLE_CACHE |
-                                   net::LOAD_BYPASS_CACHE);
-  auth_code_fetcher_->SetAutomaticallyRetryOnNetworkChanges(
-      kGetAuthCodeNetworkRetry);
-  auth_code_fetcher_->SetExtraRequestHeaders(kGetAuthCodeHeaders);
-  auth_code_fetcher_->Start();
-}
-
-void ArcAuthCodeFetcher::OnGetTokenFailure(
-    const OAuth2TokenService::Request* request,
-    const GoogleServiceAuthError& error) {
-  VLOG(2) << "Failed to get LST " << error.ToString() << ".";
-  ResetFetchers();
-  base::ResetAndReturn(&callback_).Run(std::string());
-}
-
-void ArcAuthCodeFetcher::OnURLFetchComplete(const net::URLFetcher* source) {
-  const int response_code = source->GetResponseCode();
-  std::string json_string;
-  source->GetResponseAsString(&json_string);
-
-  ResetFetchers();
-
-  if (response_code != net::HTTP_OK) {
-    VLOG(2) << "Server returned wrong response code: " << response_code << ".";
-    base::ResetAndReturn(&callback_).Run(std::string());
-    return;
-  }
-
-  JSONStringValueDeserializer deserializer(json_string);
-  std::string error_msg;
-  std::unique_ptr<base::Value> auth_code_info =
-      deserializer.Deserialize(nullptr, &error_msg);
-  if (!auth_code_info) {
-    VLOG(2) << "Unable to deserialize auth code json data: " << error_msg
-            << ".";
-    base::ResetAndReturn(&callback_).Run(std::string());
-    return;
-  }
-
-  std::unique_ptr<base::DictionaryValue> auth_code_dictionary =
-      base::DictionaryValue::From(std::move(auth_code_info));
-  if (!auth_code_dictionary) {
-    NOTREACHED();
-    base::ResetAndReturn(&callback_).Run(std::string());
-    return;
-  }
-
-  std::string auth_code;
-  if (!auth_code_dictionary->GetString(kToken, &auth_code) ||
-      auth_code.empty()) {
-    VLOG(2) << "Response does not contain auth code.";
-    base::ResetAndReturn(&callback_).Run(std::string());
-    return;
-  }
-
-  base::ResetAndReturn(&callback_).Run(auth_code);
-}
-
-void ArcAuthCodeFetcher::ResetFetchers() {
-  login_token_request_.reset();
-  auth_code_fetcher_.reset();
-}
-
-}  // namespace arc