Fix race issue in ArcAuthService.

chrome/browser/chromeos/arc/auth/arc_robot_auth_code_fetcher_browsertest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <memory>
 #include <string>
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/command_line.h"
@@ skipping 60 matching lines @@
   void Init(arc::mojom::AuthHostPtr host_ptr) override {}
   void OnAccountInfoReady(arc::mojom::AccountInfoPtr account_info) override {
     ASSERT_FALSE(callback.is_null());
     callback.Run(account_info);
   }
   base::Callback<void(const arc::mojom::AccountInfoPtr&)> callback;
 };
 
 }  // namespace
 
-class ArcRobotAuthBrowserTest : public InProcessBrowserTest {
+class ArcRobotAuthCodeFetcherBrowserTest : public InProcessBrowserTest {
  protected:
-  ArcRobotAuthBrowserTest() = default;
+  ArcRobotAuthCodeFetcherBrowserTest() = default;
 
   // InProcessBrowserTest:
-  ~ArcRobotAuthBrowserTest() override = default;
+  ~ArcRobotAuthCodeFetcherBrowserTest() override = default;
 
   void SetUpCommandLine(base::CommandLine* command_line) override {
     InProcessBrowserTest::SetUpCommandLine(command_line);
     command_line->AppendSwitchASCII(policy::switches::kDeviceManagementUrl,
                                     "http://localhost");
     command_line->AppendSwitch(chromeos::switches::kEnableArc);
   }
 
   void SetUpOnMainThread() override {
     interceptor_.reset(new policy::TestRequestInterceptor(
@@ skipping 40 matching lines @@
     return static_cast<chromeos::FakeChromeUserManager*>(
         user_manager::UserManager::Get());
   }
 
   std::unique_ptr<policy::TestRequestInterceptor> interceptor_;
   FakeAuthInstance auth_instance_;
 
  private:
   std::unique_ptr<chromeos::ScopedUserManagerEnabler> user_manager_enabler_;
 
-  DISALLOW_COPY_AND_ASSIGN(ArcRobotAuthBrowserTest);
+  DISALLOW_COPY_AND_ASSIGN(ArcRobotAuthCodeFetcherBrowserTest);
 };
 
-IN_PROC_BROWSER_TEST_F(ArcRobotAuthBrowserTest, RequestAccountInfoSuccess) {
+IN_PROC_BROWSER_TEST_F(ArcRobotAuthCodeFetcherBrowserTest,
+                       RequestAccountInfoSuccess) {
   interceptor_->PushJobCallback(base::Bind(&ResponseJob));
 
   auth_instance_.callback =
       base::Bind([](const mojom::AccountInfoPtr& account_info) {
         EXPECT_EQ(kFakeAuthCode, account_info->auth_code.value());
         EXPECT_EQ(mojom::ChromeAccountType::ROBOT_ACCOUNT,
                   account_info->account_type);
         EXPECT_FALSE(account_info->is_managed);
       });
 
   ArcAuthService::GetForTest()->RequestAccountInfo();
   base::RunLoop().RunUntilIdle();
 }
 
-IN_PROC_BROWSER_TEST_F(ArcRobotAuthBrowserTest, RequestAccountInfoError) {
+IN_PROC_BROWSER_TEST_F(ArcRobotAuthCodeFetcherBrowserTest,
+                       RequestAccountInfoError) {
   interceptor_->PushJobCallback(
       policy::TestRequestInterceptor::BadRequestJob());
 
   auth_instance_.callback =
       base::Bind([](const mojom::AccountInfoPtr&) { FAIL(); });
 
+  ArcSessionManager::Get()->StartArc();
   ArcAuthService::GetForTest()->RequestAccountInfo();
   // This MessageLoop will be stopped by AttemptUserExit(), that is called as
   // a result of error of auth code fetching.
   base::RunLoop().Run();
 }
 
 }  // namespace arc