third_party/WebKit/Source/bindings/modules/v8/serialization/V8ScriptValueSerializerForModulesTest.cpp - Issue 2547053003: s/ passed(...) / WTF::passed(...) / to avoid future ambiguity w/ base::Passed.

Unified Diff: third_party/WebKit/Source/bindings/modules/v8/serialization/V8ScriptValueSerializerForModulesTest.cpp

Issue 2547053003: s/ passed(...) / WTF::passed(...) / to avoid future ambiguity w/ base::Passed. (Closed)

Patch Set: Rebasing... Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « third_party/WebKit/Source/bindings/modules/v8/ScriptValueSerializerForModules.cpp ('k') | third_party/WebKit/Source/core/animation/Animation.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/modules/v8/serialization/V8ScriptValueSerializerForModulesTest.cpp

diff --git a/third_party/WebKit/Source/bindings/modules/v8/serialization/V8ScriptValueSerializerForModulesTest.cpp b/third_party/WebKit/Source/bindings/modules/v8/serialization/V8ScriptValueSerializerForModulesTest.cpp

index 02d601dd31b3b245d2e3f5dc135a3b958107740f..0cd888e02371ce3b11632055b482c56f62d7f0bd 100644

--- a/third_party/WebKit/Source/bindings/modules/v8/serialization/V8ScriptValueSerializerForModulesTest.cpp

+++ b/third_party/WebKit/Source/bindings/modules/v8/serialization/V8ScriptValueSerializerForModulesTest.cpp

@@ -428,8 +428,8 @@ TEST(V8ScriptValueSerializerForModulesTest, RoundTripCryptoKeyAES) {

// Check that one can decrypt data encrypted with the other.

Vector<unsigned char> iv(16, 0);

- WebCryptoAlgorithm encryptAlgorithm(WebCryptoAlgorithmIdAesCbc,

- makeUnique<WebCryptoAesCbcParams>(iv));

+ WebCryptoAlgorithm encryptAlgorithm(

+ WebCryptoAlgorithmIdAesCbc, WTF::makeUnique<WebCryptoAesCbcParams>(iv));

Vector<unsigned char> plaintext{1, 2, 3};

WebVector<uint8_t> ciphertext =

syncEncrypt(scriptState, encryptAlgorithm, key->key(), plaintext);

@@ -460,8 +460,8 @@ TEST(V8ScriptValueSerializerForModulesTest, DecodeCryptoKeyAES) {

Vector<uint8_t> iv(16, 0);

Vector<uint8_t> ciphertext{0x33, 0x26, 0xe7, 0x64, 0x11, 0x5e, 0xf4, 0x60,

0x96, 0x08, 0x11, 0xaf, 0x65, 0x8b, 0x87, 0x04};

- WebCryptoAlgorithm encryptAlgorithm(WebCryptoAlgorithmIdAesCbc,

- makeUnique<WebCryptoAesCbcParams>(iv));

+ WebCryptoAlgorithm encryptAlgorithm(

+ WebCryptoAlgorithmIdAesCbc, WTF::makeUnique<WebCryptoAesCbcParams>(iv));

WebVector<uint8_t> plaintext =

syncDecrypt(scriptState, encryptAlgorithm, newKey->key(), ciphertext);

EXPECT_THAT(plaintext, ElementsAre(1, 2, 3));

@@ -578,7 +578,7 @@ TEST(V8ScriptValueSerializerForModulesTest, RoundTripCryptoKeyRSAHashed) {

// Check that one can verify a message signed by the other.

Vector<uint8_t> message{1, 2, 3};

WebCryptoAlgorithm algorithm(WebCryptoAlgorithmIdRsaPss,

- makeUnique<WebCryptoRsaPssParams>(16));

+ WTF::makeUnique<WebCryptoRsaPssParams>(16));

WebVector<uint8_t> signature =

syncSign(scriptState, algorithm, newPrivateKey->key(), message);

EXPECT_TRUE(syncVerifySignature(scriptState, algorithm, publicKey->key(),

@@ -630,7 +630,7 @@ TEST(V8ScriptValueSerializerForModulesTest, DecodeCryptoKeyRSAHashed) {

0xeb, 0x17, 0x68, 0x1f, 0xbd, 0xfa, 0xf7, 0xd6, 0x1f, 0xa4, 0x7c, 0x9e,

0x9e, 0xb1, 0x96, 0x8f, 0xe6, 0x5e, 0x89, 0x99};

WebCryptoAlgorithm algorithm(WebCryptoAlgorithmIdRsaPss,

- makeUnique<WebCryptoRsaPssParams>(16));

+ WTF::makeUnique<WebCryptoRsaPssParams>(16));

EXPECT_TRUE(syncVerifySignature(scriptState, algorithm, newPublicKey->key(),

signature, message));

}

@@ -672,7 +672,7 @@ TEST(V8ScriptValueSerializerForModulesTest, RoundTripCryptoKeyEC) {

WebCryptoAlgorithm hash(WebCryptoAlgorithmIdSha256, nullptr);

Vector<uint8_t> message{1, 2, 3};

WebCryptoAlgorithm algorithm(WebCryptoAlgorithmIdEcdsa,

- makeUnique<WebCryptoEcdsaParams>(hash));

+ WTF::makeUnique<WebCryptoEcdsaParams>(hash));