[Interpreter] Optimize equality check with null/undefined with a check on the map.

src/interpreter/mkpeephole.cc

Index: src/interpreter/mkpeephole.cc
diff --git a/src/interpreter/mkpeephole.cc b/src/interpreter/mkpeephole.cc
index 62d3a77e02c7faf513f1d8ff020217b6fd4785dd..81f35f670112ccf002c5c971cdbc14bb590a9dbc 100644
--- a/src/interpreter/mkpeephole.cc
+++ b/src/interpreter/mkpeephole.cc
@@ -192,6 +192,19 @@ PeepholeActionAndData PeepholeActionTableWriter::LookupActionAndData(
     }
   }
 
+  // Fuse LdaNull/LdaUndefined followed by a equality comparison with test
+  // undetectable. Testing undetectable is a simple check on the map which is
+  // more efficient than the full comparison operation.
+  // Note: StrictEquals cannot use this, they need to compare it with the
+  // Null/undefined map.
+  if (last == Bytecode::kLdaNull || last == Bytecode::kLdaUndefined) {
+    if (current == Bytecode::kTestEqual) {

[mythria, 2016/12/05 17:48:12]

Ast Converts b != null to b == null. So we don't need another bytecode for
TestNotUndetectable.

[rmcilroy, 2016/12/05 19:08:09]

Great thanks for checking.

+      return {PeepholeAction::
+                  kTransformEqualityWithNullOrUndefinedToTestUndetectableAction,
+              Bytecode::kTestUndetectable};

[rmcilroy, 2016/12/05 19:08:09]

Still passing the bytecode as action data here. I think ti should just be
Bytecode::kIllegal.

[mythria, 2016/12/06 10:13:27]

Done.

+    }
+  }
+
   // If there is no last bytecode to optimize against, store the incoming
   // bytecode or for jumps emit incoming bytecode immediately.
   if (last == Bytecode::kIllegal) {