MIPS[64]: Fix jump_tables6 test for r6 architectures

MIPS[64]: Fix jump_tables6 test for r6 architectures

This patch fixes jump_tables6 test for mips32r6 and mips64r6.
This is regression from CL:
https://crrev.com/d735f3ab12061f0a588b3f0538f9229cf747f818

BUG=

Committed: https://crrev.com/c35cc1419cdc3451433bb3d2462c1be125c568c5
Cr-Commit-Position: refs/heads/master@{#41543}

[dusan.simicic, 2016-12-02 14:56:30]

dusan.simicic@imgtec.com changed reviewers:
+ ivica.bogosavljevic@imgtec.com, marija.antic@imgtec.com,
miran.karic@imgtec.com

[dusan.simicic, 2016-12-02 14:56:30]

PTAL

[ivica.bogosavljevic, 2016-12-06 09:25:35]

https://codereview.chromium.org/2547033002/diff/1/test/cctest/test-macro-asse...
File test/cctest/test-macro-assembler-mips.cc (right):

https://codereview.chromium.org/2547033002/diff/1/test/cctest/test-macro-asse...
test/cctest/test-macro-assembler-mips.cc:300: const int kInstrSize = 4;
this constant is already defined, please reuse it

https://codereview.chromium.org/2547033002/diff/1/test/cctest/test-macro-asse...
test/cctest/test-macro-assembler-mips.cc:303: const int kSwitchTablePrologueSize
= 5;
Create a constant and use it both here and in GenerateSwitchTable

https://codereview.chromium.org/2547033002/diff/1/test/cctest/test-macro-asse...
test/cctest/test-macro-assembler-mips.cc:307: const int kTrampolineSlotsSize = 4
* kInstrSize;
Generally this looks good, but these hardcoded numbers will need to find their
place in corresponding files and shared among testing code and code under test.

https://codereview.chromium.org/2547033002/diff/1/test/cctest/test-macro-asse...
test/cctest/test-macro-assembler-mips.cc:326: gen_insn +=
IsMipsArchVariant(kMips32r6) ? 1 : 2;
this count actually should be something like:
gen_insn = IsBranchCompactSupported() ? 1 : 2;

[dusan.simicic, 2016-12-06 14:19:40]

PTAL

https://codereview.chromium.org/2547033002/diff/1/test/cctest/test-macro-asse...
File test/cctest/test-macro-assembler-mips.cc (right):

https://codereview.chromium.org/2547033002/diff/1/test/cctest/test-macro-asse...
test/cctest/test-macro-assembler-mips.cc:300: const int kInstrSize = 4;
On 2016/12/06 09:25:35, ivica.bogosavljevic wrote:
> this constant is already defined, please reuse it

Done.

https://codereview.chromium.org/2547033002/diff/1/test/cctest/test-macro-asse...
test/cctest/test-macro-assembler-mips.cc:303: const int kSwitchTablePrologueSize
= 5;
On 2016/12/06 09:25:35, ivica.bogosavljevic wrote:
> Create a constant and use it both here and in GenerateSwitchTable

Done.

https://codereview.chromium.org/2547033002/diff/1/test/cctest/test-macro-asse...
test/cctest/test-macro-assembler-mips.cc:307: const int kTrampolineSlotsSize = 4
* kInstrSize;
On 2016/12/06 09:25:35, ivica.bogosavljevic wrote:
> Generally this looks good, but these hardcoded numbers will need to find their
> place in corresponding files and shared among testing code and code under
test.

kTrampolineSlotsSize constant redefined as public in Assembler class.

https://codereview.chromium.org/2547033002/diff/1/test/cctest/test-macro-asse...
test/cctest/test-macro-assembler-mips.cc:326: gen_insn +=
IsMipsArchVariant(kMips32r6) ? 1 : 2;
On 2016/12/06 09:25:35, ivica.bogosavljevic wrote:
> this count actually should be something like:
> gen_insn = IsBranchCompactSupported() ? 1 : 2;

Done.

[ivica.bogosavljevic, 2016-12-06 15:01:32]

lgtm

[dusan.simicic, 2016-12-06 15:30:22]

The CQ bit was checked by dusan.simicic@imgtec.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 15:30:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 15:49:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 15:49:23]

Dry run: This issue passed the CQ dry run.

[dusan.simicic, 2016-12-07 09:11:24]

The CQ bit was unchecked by dusan.simicic@imgtec.com

[dusan.simicic, 2016-12-07 09:11:24]

The CQ bit was checked by dusan.simicic@imgtec.com

[commit-bot: I haz the power, 2016-12-07 09:11:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 09:13:23]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481101884830260,
"parent_rev": "829c4dd4db70415598f3416ff820053c33c5ca7e", "commit_rev":
"96513d01e50550aa42a69ba1a05ba404d31fbd88"}

[commit-bot: I haz the power, 2016-12-07 09:13:32]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-07 09:13:48]

Description was changed from

==========
MIPS[64]: Fix jump_tables6 test for r6 architectures

This patch fixes jump_tables6 test for mips32r6 and mips64r6.
This is regression from CL:
https://crrev.com/d735f3ab12061f0a588b3f0538f9229cf747f818

BUG=
==========

to

==========
MIPS[64]: Fix jump_tables6 test for r6 architectures

This patch fixes jump_tables6 test for mips32r6 and mips64r6.
This is regression from CL:
https://crrev.com/d735f3ab12061f0a588b3f0538f9229cf747f818

BUG=

Committed: https://crrev.com/c35cc1419cdc3451433bb3d2462c1be125c568c5
Cr-Commit-Position: refs/heads/master@{#41543}
==========

[commit-bot: I haz the power, 2016-12-07 09:13:49]

Patchset 2 (id:??) landed as
https://crrev.com/c35cc1419cdc3451433bb3d2462c1be125c568c5
Cr-Commit-Position: refs/heads/master@{#41543}