Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 2547013003: Fuchsia: Build an OS image that includes Dart's test suite. (Closed)

Created:
4 years ago by zra
Modified:
3 years, 11 months ago
Reviewers:
siva
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fuchsia: Build an OS image that includes Dart's test suite. Guarded by a GN argument, this CL builds a Fuchsia OS image that includes Dart tree, including the test suite, packages, test harness, and sufficient build output to run through the test suite. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/306b0ec24910a4ca0efa5a512e2f47711bb78b28

Patch Set 1 #

Patch Set 2 #

Total comments: 2

Patch Set 3 : Fix copyright year. Fix comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -4 lines) Patch
M BUILD.gn View 1 2 1 chunk +74 lines, -0 lines 0 comments Download
M runtime/bin/directory_fuchsia.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
A tools/gen_fuchsia_test_manifest.py View 1 2 1 chunk +92 lines, -0 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 1 2 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
zra
Siva, this is how I'm planning to run our tests on Fuchsia. I'll update the ...
3 years, 11 months ago (2017-01-17 23:53:44 UTC) #5
zra
Siva, this is how I'm planning to run our tests on Fuchsia. I'll update the ...
3 years, 11 months ago (2017-01-17 23:53:45 UTC) #6
siva
lgtm https://codereview.chromium.org/2547013003/diff/20001/tools/gen_fuchsia_test_manifest.py File tools/gen_fuchsia_test_manifest.py (right): https://codereview.chromium.org/2547013003/diff/20001/tools/gen_fuchsia_test_manifest.py#newcode2 tools/gen_fuchsia_test_manifest.py:2: # Copyright 2016 The Dart project authors. All ...
3 years, 11 months ago (2017-01-18 23:07:07 UTC) #7
zra
https://codereview.chromium.org/2547013003/diff/20001/tools/gen_fuchsia_test_manifest.py File tools/gen_fuchsia_test_manifest.py (right): https://codereview.chromium.org/2547013003/diff/20001/tools/gen_fuchsia_test_manifest.py#newcode2 tools/gen_fuchsia_test_manifest.py:2: # Copyright 2016 The Dart project authors. All rights ...
3 years, 11 months ago (2017-01-19 18:06:14 UTC) #8
zra
3 years, 11 months ago (2017-01-19 18:11:33 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
306b0ec24910a4ca0efa5a512e2f47711bb78b28 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698