Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2546863002: Use TaskScheduler instead of WorkerPool in google_brand_chromeos.cc. (Closed)

Created:
4 years ago by fdoray
Modified:
4 years ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use TaskScheduler instead of WorkerPool in google_brand_chromeos.cc. This CL replaces base::WorkerPool::PostTask() with base::PostTaskWithTraits() call. The following traits are used: Priority: BACKGROUND User won't notice if this task takes an arbitrarily long time to complete. Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). With file IO: The task is allowed to perform synchronous IO operations. No Wait (default): The task does not wait on things other than synchronous file IO operations (e.g. WaitableEvent, ConditionVariable, join a thread, join a process, blocking system call that doesn't involve interactions with the file system). BUG=659191 Committed: https://crrev.com/6c00462bd6aacdefa971db6a1d4c2354ccf913de Cr-Commit-Position: refs/heads/master@{#436070}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M chrome/browser/google/google_brand_chromeos.cc View 2 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
fdoray
Please review this CL. In particular, make sure that the traits mentioned in the CL ...
4 years ago (2016-12-02 13:27:51 UTC) #6
fdoray
-jochen@ +pkasting@ Please review this CL. In particular, make sure that the traits mentioned in ...
4 years ago (2016-12-02 13:28:32 UTC) #8
Peter Kasting
LGTM
4 years ago (2016-12-02 21:01:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2546863002/1
4 years ago (2016-12-02 21:04:44 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 23:09:12 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-02 23:13:18 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6c00462bd6aacdefa971db6a1d4c2354ccf913de
Cr-Commit-Position: refs/heads/master@{#436070}

Powered by Google App Engine
This is Rietveld 408576698