Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 254683002: AOSP files needed for libhardware. (Closed)

Created:
6 years, 8 months ago by fjhenigman
Modified:
6 years, 7 months ago
Reviewers:
rjkroege
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

AOSP files needed for libhardware. From the kitkat-release branch - these are needed to compile hardware.c. BUG=358029 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267960

Patch Set 1 #

Patch Set 2 : add fewer files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+781 lines, -0 lines) Patch
A third_party/hwcplus/include/android/log.h View 1 chunk +128 lines, -0 lines 0 comments Download
A third_party/hwcplus/include/cutils/properties.h View 1 chunk +90 lines, -0 lines 0 comments Download
A third_party/hwcplus/include/log/log.h View 1 chunk +563 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
fjhenigman
I haven't added libhardware to the chrome build yet. I'm not sure we can do ...
6 years, 8 months ago (2014-04-24 21:06:48 UTC) #1
rjkroege
is this necessary? can't the logging work a bit like the logging in gestures? change ...
6 years, 8 months ago (2014-04-25 21:19:02 UTC) #2
fjhenigman
On 2014/04/25 21:19:02, rjkroege wrote: > is this necessary? can't the logging work a bit ...
6 years, 7 months ago (2014-05-02 05:07:02 UTC) #3
rjkroege
lgtm
6 years, 7 months ago (2014-05-02 20:39:17 UTC) #4
fjhenigman
The CQ bit was checked by fjhenigman@chromium.org
6 years, 7 months ago (2014-05-02 21:25:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fjhenigman@chromium.org/254683002/20001
6 years, 7 months ago (2014-05-02 21:25:44 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-02 23:22:34 UTC) #7
Message was sent while issue was closed.
Change committed as 267960

Powered by Google App Engine
This is Rietveld 408576698