re-enable skia caching

re-enable skia caching

This permits consecutive path drawing or text drawing to combine
if their graphics state matches. This speeds up rendering considerably
when PDFium draws in many small parts. It also allows discarding
changes to the clip state that have no effect from draw to draw.

All corpus tests draw equivalently with caching enabled or disabled.

Change the member order in CPDF_PageRenderContext so the device is
flushed before the referencing annotation is deleted.

Add more printf style debugging for test draws.

R=dsinclair@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/8f875507a986d10335e40a5f7c1679aff9770d0a

[caryclark, 2016-12-06 16:36:18]

The CQ bit was checked by caryclark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 16:36:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[caryclark, 2016-12-06 16:42:54]

The CQ bit was checked by caryclark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 16:43:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 16:58:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 16:58:52]

Dry run: This issue passed the CQ dry run.

[caryclark, 2016-12-06 18:42:55]

Description was changed from

==========
wip; reenable skia caching

Now that there's enough tests passing skiapaths to make it worthwhile,
re-enanable skia caching.

This permits consecutive path drawing or text drawing to combine
if their graphics state matches.

BUG=
==========

to

==========
re-enable skia caching

This permits consecutive path drawing or text drawing to combine
if their graphics state matches. This speeds up rendering considerably
when PDFium draws in many small parts. It also allows discarding
changes to the clip state that have no effect from draw to draw.

All corpus tests draw equivalently with caching enabled or disabled.

Change the member order in CPDF_PageRenderContext so the device is
flushed before the referencing annotation is deleted.

Add more printf style debugging for test draws.

R=dsinclair@chromium.org
==========

[caryclark, 2016-12-06 18:42:55]

caryclark@google.com changed reviewers:
+ dsinclair@chromium.org

[caryclark, 2016-12-06 18:43:11]

The CQ bit was checked by caryclark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 18:43:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsinclair, 2016-12-06 18:48:26]

https://codereview.chromium.org/2546803003/diff/200001/core/fxge/skia/fx_skia...
File core/fxge/skia/fx_skia_device.cpp (right):

https://codereview.chromium.org/2546803003/diff/200001/core/fxge/skia/fx_skia...
core/fxge/skia/fx_skia_device.cpp:667: explicit SkiaState(CFX_SkiaDeviceDriver*
pDriver)
I think the explicit is only needed in the .h file?

https://codereview.chromium.org/2546803003/diff/200001/core/fxge/skia/fx_skia...
core/fxge/skia/fx_skia_device.cpp:1839: std::unique_ptr<CFX_DIBitmap> pBack =
nullptr;
I dont' think you need the = nullptr here.

[caryclark, 2016-12-06 18:59:07]

The CQ bit was checked by caryclark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 18:59:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[caryclark, 2016-12-06 19:00:37]

https://codereview.chromium.org/2546803003/diff/200001/core/fxge/skia/fx_skia...
File core/fxge/skia/fx_skia_device.cpp (right):

https://codereview.chromium.org/2546803003/diff/200001/core/fxge/skia/fx_skia...
core/fxge/skia/fx_skia_device.cpp:667: explicit SkiaState(CFX_SkiaDeviceDriver*
pDriver)
On 2016/12/06 18:48:26, dsinclair wrote:
> I think the explicit is only needed in the .h file?

The upload lint complained.

https://codereview.chromium.org/2546803003/diff/200001/core/fxge/skia/fx_skia...
core/fxge/skia/fx_skia_device.cpp:1839: std::unique_ptr<CFX_DIBitmap> pBack =
nullptr;
On 2016/12/06 18:48:26, dsinclair wrote:
> I dont' think you need the = nullptr here.

Done.

[commit-bot: I haz the power, 2016-12-06 19:16:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 19:16:08]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-12-06 21:49:05]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-12-06 21:49:05]

lgtm

[commit-bot: I haz the power, 2016-12-06 21:49:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 21:49:34]

CQ is committing da patch.

Bot data: {"patchset_id": 240001, "attempt_start_ts": 1481060945159670,
"parent_rev": "6bdb56cad7f9e31183b90152324281ac52c4563d", "commit_rev":
"8f875507a986d10335e40a5f7c1679aff9770d0a"}

[commit-bot: I haz the power, 2016-12-06 21:49:38]

Description was changed from

==========
re-enable skia caching

This permits consecutive path drawing or text drawing to combine
if their graphics state matches. This speeds up rendering considerably
when PDFium draws in many small parts. It also allows discarding
changes to the clip state that have no effect from draw to draw.

All corpus tests draw equivalently with caching enabled or disabled.

Change the member order in CPDF_PageRenderContext so the device is
flushed before the referencing annotation is deleted.

Add more printf style debugging for test draws.

R=dsinclair@chromium.org
==========

to

==========
re-enable skia caching

This permits consecutive path drawing or text drawing to combine
if their graphics state matches. This speeds up rendering considerably
when PDFium draws in many small parts. It also allows discarding
changes to the clip state that have no effect from draw to draw.

All corpus tests draw equivalently with caching enabled or disabled.

Change the member order in CPDF_PageRenderContext so the device is
flushed before the referencing annotation is deleted.

Add more printf style debugging for test draws.

R=dsinclair@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/8f875507a986d10335e40a5f7c1679aff977...
==========

[commit-bot: I haz the power, 2016-12-06 21:49:39]

Committed patchset #13 (id:240001) as
https://pdfium.googlesource.com/pdfium/+/8f875507a986d10335e40a5f7c1679aff977...