Attempt to reduce flakiness rate of io test

Attempt to reduce flakiness rate of io test

BUG=https://github.com/dart-lang/sdk/issues/27951
R=fschneider@google.com

Committed: https://github.com/dart-lang/sdk/commit/4d3af003820bd485be19b2b553e891d03cd8dfb6

[kustermann, 2016-12-01 13:35:51]

kustermann@google.com changed reviewers:
+ fschneider@google.com

[kustermann, 2016-12-01 13:35:51]

Though this CL could also make it worse.

[Florian Schneider, 2016-12-01 18:04:18]

https://codereview.chromium.org/2546733002/diff/1/tests/standalone/io/socket_...
File tests/standalone/io/socket_source_address_test.dart (right):

https://codereview.chromium.org/2546733002/diff/1/tests/standalone/io/socket_...
tests/standalone/io/socket_source_address_test.dart:141:
testArguments(RawSocket.connect);
Should this be done with a retry similar to the socket_bind_test?

Overall, I wonder what the point of these tests are if they are trying to do
something that may not succeed depending on other processes in the system, like
trying to get a free port for ipv4 and ipv6. Seems like a bad test.

[kustermann, 2016-12-02 08:56:11]

https://codereview.chromium.org/2546733002/diff/1/tests/standalone/io/socket_...
File tests/standalone/io/socket_source_address_test.dart (right):

https://codereview.chromium.org/2546733002/diff/1/tests/standalone/io/socket_...
tests/standalone/io/socket_source_address_test.dart:141:
testArguments(RawSocket.connect);
> Should this be done with a retry similar to the socket_bind_test?

I've added retries as I did in the other test a few months ago.

> Overall, I wonder what the point of these tests are if they are trying to do
> something that may not succeed depending on other processes in the system,
like
> trying to get a free port for ipv4 and ipv6. Seems like a bad test.

I agree that these tests are not ideal.

[Florian Schneider, 2016-12-02 19:20:53]

Lgtm.

Thanks, let's try that.

[kustermann, 2016-12-05 13:39:32]

Description was changed from

==========
Attempt to reduce flakiness rate of io test

BUG=https://github.com/dart-lang/sdk/issues/27951
==========

to

==========
Attempt to reduce flakiness rate of io test

BUG=https://github.com/dart-lang/sdk/issues/27951
R=fschneider@google.com

Committed:
https://github.com/dart-lang/sdk/commit/4d3af003820bd485be19b2b553e891d03cd8dfb6
==========

[kustermann, 2016-12-05 13:39:33]

Committed patchset #2 (id:20001) manually as
4d3af003820bd485be19b2b553e891d03cd8dfb6 (presubmit successful).