Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 254673005: Move JSON-stringify webkit test to V8. (Closed)

Created:
6 years, 8 months ago by ulan
Modified:
6 years, 8 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Visibility:
Public.

Description

Move JSON-stringify webkit test to V8. BUG=367089 LOG=N R=machenbach@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20977

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1558 lines, -8 lines) Patch
A test/webkit/resources/JSON-stringify.js View 1 1 chunk +529 lines, -0 lines 0 comments Download
A test/webkit/resources/json2-es5-compat.js View 1 1 chunk +481 lines, -0 lines 0 comments Download
A + test/webkit/run-json-stringify.js View 1 1 chunk +4 lines, -7 lines 0 comments Download
A test/webkit/run-json-stringify-expected.txt View 1 chunk +544 lines, -0 lines 0 comments Download
M tools/blink_tests/TestExpectations View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
ulan
PTAL. The difference between this and the original webkit test is that JSON depth of ...
6 years, 8 months ago (2014-04-25 12:27:07 UTC) #1
Michael Achenbach
lgtm
6 years, 8 months ago (2014-04-25 12:49:00 UTC) #2
ulan
6 years, 8 months ago (2014-04-25 12:50:27 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r20977 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698