Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2546693004: Re-arrange API orders in OffscreenCanvasRenderingContext2D.idl (Closed)

Created:
4 years ago by xidachen
Modified:
4 years ago
Reviewers:
Justin Novosad
CC:
chromium-reviews, blink-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-arrange API orders in OffscreenCanvasRenderingContext2D.idl This will make the APIs appear in the same order as in the CanvasRenderingContext2D.idl which makes it easy to identify which ones are missing. TBR=junov@chromium.org BUG=None Committed: https://crrev.com/84653a9b3ff30392170864588908758fa3682133 Cr-Commit-Position: refs/heads/master@{#436124}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -35 lines) Patch
M third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.idl View 4 chunks +34 lines, -35 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2546693004/1
4 years ago (2016-12-02 17:09:26 UTC) #2
Justin Novosad
lgtm
4 years ago (2016-12-02 18:09:58 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/342942)
4 years ago (2016-12-02 21:52:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2546693004/1
4 years ago (2016-12-03 01:20:56 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-03 01:26:16 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-03 01:28:34 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/84653a9b3ff30392170864588908758fa3682133
Cr-Commit-Position: refs/heads/master@{#436124}

Powered by Google App Engine
This is Rietveld 408576698