Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 2546653005: Use official server for generating WebAPKs (Closed)

Created:
4 years ago by pkotwicz
Modified:
4 years ago
Reviewers:
dominickn, hartmanng
CC:
chromium-reviews, zpeng+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use official server for generating WebAPKs BUG=670443 Committed: https://crrev.com/ff288c520e9f821b40af53fa0af6a295a815c360 Cr-Commit-Position: refs/heads/master@{#435934}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/android/webapk/webapk_installer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
pkotwicz
Glenn, can you please take a look?
4 years ago (2016-12-01 21:18:42 UTC) #3
hartmanng
lgtm, thanks Peter!
4 years ago (2016-12-01 21:19:52 UTC) #4
pkotwicz
Dominick, can you please take a look?
4 years ago (2016-12-02 00:56:09 UTC) #6
dominickn
lgtm
4 years ago (2016-12-02 03:36:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2546653005/1
4 years ago (2016-12-02 14:38:10 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 15:03:24 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-02 15:05:46 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ff288c520e9f821b40af53fa0af6a295a815c360
Cr-Commit-Position: refs/heads/master@{#435934}

Powered by Google App Engine
This is Rietveld 408576698