 Chromium Code Reviews
 Chromium Code Reviews Issue 2546653003:
  Factor out upload progress handling from AsyncResourceHandler  (Closed)
    
  
    Issue 2546653003:
  Factor out upload progress handling from AsyncResourceHandler  (Closed) 
  | Index: content/browser/loader/upload_progress_tracker.h | 
| diff --git a/content/browser/loader/upload_progress_tracker.h b/content/browser/loader/upload_progress_tracker.h | 
| new file mode 100644 | 
| index 0000000000000000000000000000000000000000..a82174e1144df8a103f3a5e2d13fde7826d2c40a | 
| --- /dev/null | 
| +++ b/content/browser/loader/upload_progress_tracker.h | 
| @@ -0,0 +1,55 @@ | 
| +// Copyright 2016 The Chromium Authors. All rights reserved. | 
| +// Use of this source code is governed by a BSD-style license that can be | 
| +// found in the LICENSE file. | 
| + | 
| +#ifndef CONTENT_BROWSER_LOADER_UPLOAD_PROGRESS_TRACKER_H_ | 
| +#define CONTENT_BROWSER_LOADER_UPLOAD_PROGRESS_TRACKER_H_ | 
| + | 
| +#include <stdint.h> | 
| + | 
| +#include "base/callback.h" | 
| +#include "base/macros.h" | 
| +#include "base/time/time.h" | 
| +#include "base/timer/timer.h" | 
| + | 
| +namespace tracked_objects { | 
| +class Location; | 
| +} | 
| + | 
| +namespace net { | 
| +class URLRequest; | 
| +} | 
| + | 
| +namespace content { | 
| + | 
| +class UploadProgressTracker final { | 
| 
yhirano
2016/12/02 09:17:52
Plase write some comments.
 
tzik
2016/12/05 08:00:06
Done.
 | 
| + public: | 
| + using UploadProgressReportCallback = | 
| + base::RepeatingCallback<void(int64_t, int64_t)>; | 
| + | 
| + UploadProgressTracker(const tracked_objects::Location& location, | 
| + UploadProgressReportCallback report_progress, | 
| + net::URLRequest* request); | 
| + ~UploadProgressTracker(); | 
| + | 
| + void OnAckReceived(); | 
| + void ForceReportUploadProgress(); | 
| + | 
| + private: | 
| + void ReportUploadProgressIfNeeded(); | 
| + | 
| + net::URLRequest* request_; // Not owned. | 
| + | 
| + uint64_t last_upload_position_ = 0; | 
| + bool waiting_for_upload_progress_ack_ = false; | 
| 
yhirano
2016/12/02 09:17:52
This is not used.
 
tzik
2016/12/05 08:00:06
Oops. Fixed. Now, it's used.
 | 
| + base::TimeTicks last_upload_ticks_; | 
| + base::RepeatingTimer progress_timer_; | 
| + | 
| + UploadProgressReportCallback report_progress_; | 
| + | 
| + DISALLOW_COPY_AND_ASSIGN(UploadProgressTracker); | 
| +}; | 
| + | 
| +} // namespace content | 
| + | 
| +#endif // CONTENT_BROWSER_LOADER_UPLOAD_PROGRESS_TRACKER_H_ |