media: Fix media_mojo_shell_unittests

media/mojo/services/BUILD.gn

Index: media/mojo/services/BUILD.gn
diff --git a/media/mojo/services/BUILD.gn b/media/mojo/services/BUILD.gn
index c2f93d7e3463eb5b3a384af11395aa7ef0de7fb3..58f152d72cc9a0396e62e0de1c4d66b79ecc7a22 100644
--- a/media/mojo/services/BUILD.gn
+++ b/media/mojo/services/BUILD.gn
@@ -49,6 +49,15 @@ config("mojo_media_config") {
 component("services") {
   output_name = "media_mojo_services"
 
+  public_deps = [
+    ":media_service",
+  ]
+}
+
+# TODO(xhwang): Add this intermediate target because ServiceTest doesn't support
+# services that depend on shared libraries in component build.
+# See http://crbug.com/670094
+source_set("media_service") {

[alokp, 2016/12/01 18:36:11]

nit: would it make sense to make "services" target a source_set so that we do
not have to create this target? Also, the target name is confusing to me - too
many media services. If you decide to keep this target, may be rename it to
"lib"?

[xhwang, 2016/12/01 22:02:13]

We did use source_set before that there was a bug in that case:

https://chromium.googlesource.com/chromium/src/+/d3b5d3f46840aba12d0788a14f14...
https://bugs.chromium.org/p/chromium/issues/detail?id=610904
Done.

I hope http://crbug.com/670094 will be fixed soon then we don't need this hack.

   sources = [
     "demuxer_stream_provider_shim.cc",
     "demuxer_stream_provider_shim.h",
@@ -126,15 +135,19 @@ service("media") {
   ]
 
   public_deps = [
-    ":services",
     "//base",
     "//media",
   ]
 
   deps = [
+    ":media_service",
     "//mojo/public/c/system",
     "//services/service_manager/public/cpp",
   ]
+
+  data_deps = [
+    ":media_manifest",
+  ]
 }
 
 test("media_mojo_shell_unittests") {
@@ -157,8 +170,8 @@ test("media_mojo_shell_unittests") {
   ]
 
   data_deps = [
-    "//media/mojo/services:test_manifest",
-    "//media/mojo/services:media",
+    ":media",
+    ":test_manifest",
   ]
 }