media: Fix media_mojo_shell_unittests

media: Fix media_mojo_shell_unittests

This test is very broken after various mojo/media changes. Today it's
passing on some fyi bots only because we are lucky.

This CL fixes the tests so that it's passing locally.

TODO in later CLs:
- The naming needs to be updated as well
- Merge this test into media_mojo_tests

BUG=656112
TEST=Fix existing tests.

Committed: https://crrev.com/6d256f62161cf485d02752780ae74b4704f7d8d3
Cr-Commit-Position: refs/heads/master@{#435764}

[xhwang, 2016-12-01 01:02:43]

The CQ bit was checked by xhwang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 01:03:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 01:05:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 01:05:58]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[xhwang, 2016-12-01 07:07:43]

rebase only

[xhwang, 2016-12-01 07:10:55]

The CQ bit was checked by xhwang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 07:11:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 07:14:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 07:14:59]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[xhwang, 2016-12-01 09:04:24]

The CQ bit was checked by xhwang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 09:04:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 10:38:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 10:38:02]

Dry run: This issue passed the CQ dry run.

[xhwang, 2016-12-01 17:49:49]

xhwang@chromium.org changed reviewers:
+ alokp@chromium.org

[xhwang, 2016-12-01 17:49:50]

alokp: You have the most background on this test where we actually used the
standalone media library before :) PTAL

slan: FYI. This CL can be smaller after your CL is landed.

[alokp, 2016-12-01 18:36:11]

lgtm

https://codereview.chromium.org/2546633002/diff/40001/media/mojo/services/BUI...
File media/mojo/services/BUILD.gn (right):

https://codereview.chromium.org/2546633002/diff/40001/media/mojo/services/BUI...
media/mojo/services/BUILD.gn:60: source_set("media_service") {
nit: would it make sense to make "services" target a source_set so that we do
not have to create this target? Also, the target name is confusing to me - too
many media services. If you decide to keep this target, may be rename it to
"lib"?

[xhwang, 2016-12-01 22:01:30]

comments addressed

[xhwang, 2016-12-01 22:01:58]

The CQ bit was checked by xhwang@chromium.org to run a CQ dry run

[xhwang, 2016-12-01 22:02:13]

Thanks for the quick review!

https://codereview.chromium.org/2546633002/diff/40001/media/mojo/services/BUI...
File media/mojo/services/BUILD.gn (right):

https://codereview.chromium.org/2546633002/diff/40001/media/mojo/services/BUI...
media/mojo/services/BUILD.gn:60: source_set("media_service") {
On 2016/12/01 18:36:11, alokp wrote:
> nit: would it make sense to make "services" target a source_set so that we do
> not have to create this target?

We did use source_set before that there was a bug in that case:

https://chromium.googlesource.com/chromium/src/+/d3b5d3f46840aba12d0788a14f14...
https://bugs.chromium.org/p/chromium/issues/detail?id=610904

> Also, the target name is confusing to me - too
> many media services. If you decide to keep this target, may be rename it to
> "lib"?

Done.

I hope http://crbug.com/670094 will be fixed soon then we don't need this hack.

[commit-bot: I haz the power, 2016-12-01 22:03:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xhwang, 2016-12-01 23:03:16]

The CQ bit was unchecked by xhwang@chromium.org

[xhwang, 2016-12-01 23:03:17]

The CQ bit was checked by xhwang@chromium.org

[xhwang, 2016-12-01 23:03:18]

The patchset sent to the CQ was uploaded after l-g-t-m from alokp@chromium.org
Link to the patchset: https://codereview.chromium.org/2546633002/#ps60001
(title: "comments addressed")

[commit-bot: I haz the power, 2016-12-01 23:03:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 23:42:26]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1480633397879230,
"parent_rev": "38f179591c7d7f82f41db14baebeafdd8657da74", "commit_rev":
"243f646cbb7f3a5707627a6dc5b15bafba5f04b0"}

[commit-bot: I haz the power, 2016-12-01 23:43:03]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-01 23:44:39]

Description was changed from

==========
media: Fix media_mojo_shell_unittests

This test is very broken after various mojo/media changes. Today it's
passing on some fyi bots only because we are lucky.

This CL fixes the tests so that it's passing locally.

TODO in later CLs:
- The naming needs to be updated as well
- Merge this test into media_mojo_tests

BUG=656112
TEST=Fix existing tests.
==========

to

==========
media: Fix media_mojo_shell_unittests

This test is very broken after various mojo/media changes. Today it's
passing on some fyi bots only because we are lucky.

This CL fixes the tests so that it's passing locally.

TODO in later CLs:
- The naming needs to be updated as well
- Merge this test into media_mojo_tests

BUG=656112
TEST=Fix existing tests.

Committed: https://crrev.com/6d256f62161cf485d02752780ae74b4704f7d8d3
Cr-Commit-Position: refs/heads/master@{#435764}
==========

[commit-bot: I haz the power, 2016-12-01 23:44:40]

Patchset 4 (id:??) landed as
https://crrev.com/6d256f62161cf485d02752780ae74b4704f7d8d3
Cr-Commit-Position: refs/heads/master@{#435764}