Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(884)

Unified Diff: build/mac/should_use_hermetic_xcode.py

Issue 2546613004: Enable hermetic builds for iOS. (Closed)
Patch Set: Update should_use_hermetic_xcode.py usage Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build_overrides/build.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/mac/should_use_hermetic_xcode.py
diff --git a/build/mac/should_use_hermetic_xcode.py b/build/mac/should_use_hermetic_xcode.py
index 14ddfacdc5020b780334eb838ebe9bfddbd06314..e386911ffdfe810c01d269461eeef0c2a1775361 100755
--- a/build/mac/should_use_hermetic_xcode.py
+++ b/build/mac/should_use_hermetic_xcode.py
@@ -4,7 +4,11 @@
# found in the LICENSE file.
"""Prints "1" if Chrome targets should be built with hermetic xcode. Otherwise
-prints "0"."""
+prints "0".
+
+Usage:
+ python should_user-hermetic_xcode.py <target_os>
Robert Sesek 2016/12/07 19:55:44 nit: typo here
justincohen 2016/12/08 03:25:15 Done.
+"""
import os
import sys
@@ -15,7 +19,8 @@ def _IsCorpMachine():
def main():
- if os.environ.get('FORCE_MAC_TOOLCHAIN') or _IsCorpMachine():
+ allow_corp = sys.argv[1] == "mac" and _IsCorpMachine()
Robert Sesek 2016/12/07 19:55:44 nit: single quotes for mac ?
justincohen 2016/12/08 03:25:15 Done.
+ if os.environ.get('FORCE_MAC_TOOLCHAIN') or allow_corp:
return "1"
else:
return "0"
« no previous file with comments | « no previous file | build_overrides/build.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698