Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2546613002: Revert of Fix leaks in InputConnectionHandlerThread (Closed)

Created:
4 years ago by Changwan Ryu
Modified:
4 years ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix leaks in InputConnectionHandlerThread (patchset #2 id:20001 of https://codereview.chromium.org/2537073002/ ) Reason for revert: caused crbug.com/669886 Original issue's description: > Fix leaks in InputConnectionHandlerThread > > On destruction of ContentViewCore and on view detachment, we reset mHandler, > allowing it a chance to be garbage-collected. > > BUG=668692 > > Committed: https://crrev.com/c703b49a25b8b279fe7cbd1fbfe7ff67493fbf7b > Cr-Commit-Position: refs/heads/master@{#435136} TBR=tobiasjs@chromium.org,aelias@chromium.org,yabinh@chromium.org,torne@chromium.org,tedchoc@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=668692 Committed: https://crrev.com/0b968c4c01cc7c20f7f8c807a566def4559965af Cr-Commit-Position: refs/heads/master@{#435506}

Patch Set 1 #

Messages

Total messages: 7 (3 generated)
Changwan Ryu
Created Revert of Fix leaks in InputConnectionHandlerThread
4 years ago (2016-12-01 00:53:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2546613002/1
4 years ago (2016-12-01 00:54:18 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 00:55:55 UTC) #5
commit-bot: I haz the power
4 years ago (2016-12-01 00:58:29 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0b968c4c01cc7c20f7f8c807a566def4559965af
Cr-Commit-Position: refs/heads/master@{#435506}

Powered by Google App Engine
This is Rietveld 408576698