Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 2546603002: Fixed Tab switcher UI misalignment (Closed)

Created:
4 years ago by shaktisahu
Modified:
4 years ago
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed Tab switcher UI misalignment Tab switcher sometimes hides one tab stack incorrectly if sufficient time has not elapsed between creating a new tab and tapping on tab switcher. Cancelling the unfinished animation before starting a new animation fixes this bug. BUG=571364 Committed: https://crrev.com/bffc40ae72a435230ec2f02cb6834d10dbfbdfc1 Cr-Commit-Position: refs/heads/master@{#435660}

Patch Set 1 #

Total comments: 1

Patch Set 2 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/StackLayout.java View 1 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
shaktisahu
4 years ago (2016-12-01 00:45:45 UTC) #2
David Trainor- moved to gerrit
lgtm https://codereview.chromium.org/2546603002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/StackLayout.java File chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/StackLayout.java (right): https://codereview.chromium.org/2546603002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/StackLayout.java#newcode487 chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/StackLayout.java:487: cancelAnimation(this, Property.STACK_OFFSET_Y_PERCENT); Add the comment here as well?
4 years ago (2016-12-01 17:35:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2546603002/20001
4 years ago (2016-12-01 18:10:29 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-01 18:45:24 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-01 18:47:51 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bffc40ae72a435230ec2f02cb6834d10dbfbdfc1
Cr-Commit-Position: refs/heads/master@{#435660}

Powered by Google App Engine
This is Rietveld 408576698