DevTools: [Persistence] guard against multiple UISourceCodes with similar URL

third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 /**
  * @unrestricted
  */
 Persistence.Persistence = class extends Common.Object {
   /**
    * @param {!Workspace.Workspace} workspace
    * @param {!Bindings.BreakpointManager} breakpointManager
@@ skipping 14 matching lines @@
     } else {
       this._mapping = new Persistence.DefaultMapping(
           workspace, fileSystemMapping, this._onBindingCreated.bind(this), this._onBindingRemoved.bind(this));
     }
   }
 
   /**
    * @param {!Persistence.PersistenceBinding} binding
    */
   _onBindingCreated(binding) {
+    // FIXME(lushnikov): workspace should contain only one UISourceCode per URL.

[dgozman, 2016/12/01 18:29:05]

TODO

+    if (binding.network[Persistence.Persistence._binding] || binding.fileSystem[Persistence.Persistence._binding])

[dgozman, 2016/12/01 18:29:06]

I think we should move this check to both mappings instead.

[lushnikov, 2016/12/02 01:54:55]

Since Persistence instance is nicely isolated from mappings - this feels like a
good place by itself. wdyt?

+      return;
     if (binding.network.isDirty()) {
       Common.console.log(
           Common.UIString('%s can not be persisted to file system due to unsaved changes.', binding.network.name()));
       return;
     }
     if (binding.fileSystem.isDirty())
       binding.network.setWorkingCopy(binding.fileSystem.workingCopy());
 
     binding.network[Persistence.Persistence._binding] = binding;
     binding.fileSystem[Persistence.Persistence._binding] = binding;
@@ skipping 196 matching lines @@
    */
   constructor(network, fileSystem, exactMatch) {
     this.network = network;
     this.fileSystem = fileSystem;
     this.exactMatch = exactMatch;
   }
 };
 
 /** @type {!Persistence.Persistence} */
 Persistence.persistence;