Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 2546553002: [wasm] [asm.js] Ignore unused function tables in AsmWasmBuilder. (Closed)

Created:
4 years ago by bradnelson
Modified:
4 years ago
Reviewers:
aseemgarg, bradn
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] [asm.js] Ignore unused function tables in AsmWasmBuilder. Incremental parsing of asm.js means we can see function tables that are unused in the AsmWasmBuilder before they've been initialized. BUG=669899 R=aseemgarg@chromium.org Committed: https://crrev.com/00ec48335e10a6dca45435e95cf4a9613e399edd Cr-Commit-Position: refs/heads/master@{#41403}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -1 line) Patch
M src/asmjs/asm-wasm-builder.cc View 1 chunk +4 lines, -1 line 0 comments Download
A test/mjsunit/asm/regress-669899.js View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
bradn
4 years ago (2016-11-30 19:38:35 UTC) #2
aseemgarg
lgtm
4 years ago (2016-12-01 01:32:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2546553002/1
4 years ago (2016-12-01 02:02:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 02:27:03 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-01 02:27:41 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/00ec48335e10a6dca45435e95cf4a9613e399edd
Cr-Commit-Position: refs/heads/master@{#41403}

Powered by Google App Engine
This is Rietveld 408576698