Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issue 2546533004: Update the Mac version of d8 (Closed)

Created:
4 years ago by charliea (OOO until 10-5)
Modified:
4 years ago
Reviewers:
nednguyen
CC:
catapult-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Update the Mac version of d8 third_party/vinn/bin/run_tests and tracing/bin/run_vinn_tests both succeeded with no failures. R=nednguyen@google.com Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/760530e4994ad2d4a6d68dceead76e588fdb9a04

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/vinn/third_party/v8/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/vinn/third_party/v8/mac/x86_64/d8 View Binary file 0 comments Download

Messages

Total messages: 7 (4 generated)
charliea (OOO until 10-5)
4 years ago (2016-12-01 21:08:14 UTC) #1
nednguyen
lgtm
4 years ago (2016-12-01 21:12:21 UTC) #4
charliea (OOO until 10-5)
4 years ago (2016-12-01 21:15:23 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
760530e4994ad2d4a6d68dceead76e588fdb9a04 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698