Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_service.cc

Issue 2546533003: Respect QuicAllowed policy for new streams (Closed)
Patch Set: Make explicit that we are only disabling QUIC dynamically Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_service.h ('k') | chrome/common/pref_names.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/safe_browsing_service.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_service.cc b/chrome/browser/safe_browsing/safe_browsing_service.cc
index d124f5a5afa72b017b5e3bbc8227dce09df5b740..17bdd009a1f30a1e615c40ff1d7fd3ee10c64c87 100644
--- a/chrome/browser/safe_browsing/safe_browsing_service.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_service.cc
@@ -139,6 +139,10 @@ class SafeBrowsingURLRequestContextGetter
// true.
void ServiceShuttingDown();
+ // Disables QUIC. This should not be necessary anymore when
+ // http://crbug.com/678653 is implemented.
+ void DisableQuicOnIOThread();
+
protected:
~SafeBrowsingURLRequestContextGetter() override;
@@ -239,6 +243,13 @@ void SafeBrowsingURLRequestContextGetter::ServiceShuttingDown() {
safe_browsing_request_context_.reset();
}
+void SafeBrowsingURLRequestContextGetter::DisableQuicOnIOThread() {
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
+
+ if (http_network_session_)
+ http_network_session_->DisableQuic();
+}
+
SafeBrowsingURLRequestContextGetter::~SafeBrowsingURLRequestContextGetter() {}
// static
@@ -393,6 +404,14 @@ SafeBrowsingService::url_request_context() {
return url_request_context_getter_;
}
+void SafeBrowsingService::DisableQuicOnIOThread() {
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
+
+ url_request_context_getter_->DisableQuicOnIOThread();
+}
+
+// TODO(ntfschr): componentize this once BaseSafeBrowsingUIManager contains a
Nathan Parker 2017/01/09 20:00:21 This looks like a merge confusion.
pmarko 2017/01/09 20:25:23 Good catch, removed.
+// SafeBrowsingService
const scoped_refptr<SafeBrowsingUIManager>&
SafeBrowsingService::ui_manager() const {
return ui_manager_;
« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_service.h ('k') | chrome/common/pref_names.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698