Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1444)

Unified Diff: net/quic/chromium/quic_network_transaction_unittest.cc

Issue 2546533003: Respect QuicAllowed policy for new streams (Closed)
Patch Set: IOS io_thread also initializes DynamicSharedParams Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/chromium/quic_network_transaction_unittest.cc
diff --git a/net/quic/chromium/quic_network_transaction_unittest.cc b/net/quic/chromium/quic_network_transaction_unittest.cc
index 1b5b54dafc435b96e1aca05f5bceff3554cf7969..3fc4cac28d0ccbab42bd014946b829d1e8434ff0 100644
--- a/net/quic/chromium/quic_network_transaction_unittest.cc
+++ b/net/quic/chromium/quic_network_transaction_unittest.cc
@@ -479,7 +479,8 @@ class QuicNetworkTransactionTest
}
void CreateSession() {
- params_.enable_quic = true;
+ params_.dynamic_shared_params = &dynamic_shared_params_;
+ dynamic_shared_params_.enable_quic = true;
params_.quic_clock = clock_;
params_.quic_random = &random_generator_;
params_.client_socket_factory = &socket_factory_;
@@ -723,6 +724,7 @@ class QuicNetworkTransactionTest
MockRandom random_generator_;
HttpServerPropertiesImpl http_server_properties_;
HttpNetworkSession::Params params_;
+ HttpNetworkSession::DynamicSharedParams dynamic_shared_params_;
HttpRequestInfo request_;
BoundTestNetLog net_log_;
std::vector<std::unique_ptr<StaticSocketDataProvider>> hanging_data_;
@@ -853,7 +855,7 @@ TEST_P(QuicNetworkTransactionTest, ForceQuicForAll) {
}
TEST_P(QuicNetworkTransactionTest, QuicProxy) {
- params_.enable_quic = true;
+ dynamic_shared_params_.enable_quic = true;
proxy_service_ =
ProxyService::CreateFixedFromPacResult("QUIC mail.example.org:70");
@@ -895,7 +897,7 @@ TEST_P(QuicNetworkTransactionTest, QuicProxyWithCert) {
const std::string origin_host = "mail.example.com";
const std::string proxy_host = "www.example.org";
- params_.enable_quic = true;
+ dynamic_shared_params_.enable_quic = true;
proxy_service_ =
ProxyService::CreateFixedFromPacResult("QUIC " + proxy_host + ":70");
@@ -3031,7 +3033,8 @@ class QuicNetworkTransactionWithDestinationTest
MockCryptoClientStream::CONFIRM_HANDSHAKE);
params.quic_crypto_client_stream_factory = &crypto_client_stream_factory_;
- params.enable_quic = true;
+ dynamic_shared_params_.enable_quic = true;
+ params.dynamic_shared_params = &dynamic_shared_params_;
params.quic_random = &random_generator_;
params.client_socket_factory = &socket_factory_;
params.host_resolver = &host_resolver_;
@@ -3234,6 +3237,7 @@ class QuicNetworkTransactionWithDestinationTest
std::vector<std::unique_ptr<StaticSocketDataProvider>>
static_socket_data_provider_vector_;
SSLSocketDataProvider ssl_data_;
+ HttpNetworkSession::DynamicSharedParams dynamic_shared_params_;
};
INSTANTIATE_TEST_CASE_P(Version,

Powered by Google App Engine
This is Rietveld 408576698