Respect QuicAllowed policy for new streams

chrome/browser/profiles/profile_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_impl.h"
 
 #include <stddef.h>
 
 #include <memory>
 #include <utility>
@@ skipping 26 matching lines @@
 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/content_settings/cookie_settings_factory.h"
 #include "chrome/browser/content_settings/host_content_settings_map_factory.h"
 #include "chrome/browser/dom_distiller/profile_utils.h"
 #include "chrome/browser/domain_reliability/service_factory.h"
 #include "chrome/browser/download/chrome_download_manager_delegate.h"
 #include "chrome/browser/download/download_service.h"
 #include "chrome/browser/download/download_service_factory.h"
+#include "chrome/browser/net/net_pref_observer.h"
 #include "chrome/browser/net/predictor.h"
 #include "chrome/browser/net/proxy_service_factory.h"
 #include "chrome/browser/permissions/permission_manager.h"
 #include "chrome/browser/permissions/permission_manager_factory.h"
 #include "chrome/browser/plugins/chrome_plugin_service_filter.h"
 #include "chrome/browser/plugins/plugin_prefs.h"
 #include "chrome/browser/policy/profile_policy_connector.h"
 #include "chrome/browser/policy/profile_policy_connector_factory.h"
 #include "chrome/browser/policy/schema_registry_service.h"
 #include "chrome/browser/policy/schema_registry_service_factory.h"
@@ skipping 51 matching lines @@
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/dom_storage_context.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/storage_partition.h"
 #include "content/public/browser/url_data_source.h"
 #include "content/public/browser/user_metrics.h"
 #include "content/public/common/content_constants.h"
 #include "content/public/common/page_zoom.h"
 #include "extensions/features/features.h"
+#include "net/http/http_network_session.h"
 #include "ppapi/features/features.h"
 #include "printing/features/features.h"
 #include "ui/base/l10n/l10n_util.h"
 
 #if defined(OS_CHROMEOS)
 #include "chrome/browser/chromeos/locale_change_guard.h"
 #include "chrome/browser/chromeos/preferences.h"
 #include "chrome/browser/chromeos/profiles/profile_helper.h"
 #include "components/user_manager/user_manager.h"
 #endif
@@ skipping 487 matching lines @@
 
   // Make sure we initialize the ProfileIOData after everything else has been
   // initialized that we might be reading from the IO thread.
 
   io_data_.Init(cookie_path, channel_id_path, cache_path,
                 cache_max_size, media_cache_path, media_cache_max_size,
                 extensions_cookie_path, GetPath(), predictor_,
                 session_cookie_mode, GetSpecialStoragePolicy(),
                 CreateDomainReliabilityMonitor(local_state));
 
+  DCHECK(!net_pref_observer_);
+  NetPrefObserver::UpdateNetParamsCallback update_net_params_callback =
+      base::Bind(&ProfileImpl::UpdateNetParams, base::Unretained(this));
+  net_pref_observer_ = base::MakeUnique<NetPrefObserver>(
+      prefs_.get(), update_net_params_callback);
+
 #if BUILDFLAG(ENABLE_PLUGINS)
   ChromePluginServiceFilter::GetInstance()->RegisterResourceContext(
       this, io_data_.GetResourceContextNoInit());
 #endif
 
   TRACE_EVENT0("browser", "ProfileImpl::SetSaveSessionStorageOnDisk");
   content::BrowserContext::GetDefaultStoragePartition(this)->
       GetDOMStorageContext()->SetSaveSessionStorageOnDisk();
 
   // The DomDistillerViewerSource is not a normal WebUI so it must be registered
@@ skipping 640 matching lines @@
 ProfileImpl::CreateDomainReliabilityMonitor(PrefService* local_state) {
   domain_reliability::DomainReliabilityService* service =
       domain_reliability::DomainReliabilityServiceFactory::GetInstance()->
           GetForBrowserContext(this);
   if (!service)
     return std::unique_ptr<domain_reliability::DomainReliabilityMonitor>();
 
   return service->CreateMonitor(
       BrowserThread::GetTaskRunnerForThread(BrowserThread::IO));
 }
+
+void ProfileImpl::UpdateNetParams(
+    NetPrefObserver::NetParamsChange net_params_change) {
+  io_data_.UpdateNetParams(net_params_change);

[mmenke, 2017/01/03 18:49:40]

BUG:  There are potentially multiple profiles.  IOData shouldn't just follow the
parameters of the one which had its QUIC status most recently changed.  Not sure
how group policy is normally applied to global objects.

[pmarko, 2017/01/03 19:30:49]

As far as I can see, this is not actually global - every Profile(Impl) has its
own io_data_ - it's an instance of a ProfileIOData subclass (here,
ProfileImplIOData) owned by the profile. Or am I missing something here?

But yes, there are global HttpNetworkSessions owned by io_thread /
g_browser_process->safe_browsing_service() , these are updated directly from
NetPrefObserver, so your concern does indeed apply to these.

That's why NetPrefObserver only propagates changes true->false, see
net_pref_observer.cc:58. This way, changes false->true require a restart, but
that's OK with the customer needing this so it might be a good compromise. If we
didn't do that, we'd have to keep a look at all profiles, && their quicallowed
all together and pass that to the globally-owned HttpNetworkSessions, or
something like that.

[mmenke, 2017/01/03 19:35:42]

Oops, sorry, was thinking this was IOData...Where is IOData's corresponding
method called?

+}