Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issue 2546523004: <webview> Fix crash when closing chrome://chrome-signin (Closed)

Created:
4 years ago by wjmaclean
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

<webview> Fix crash when closing chrome://chrome-signin This fixes a browser crash with OOPIF-based webviews. When two instances of chrome://chrome-signin are opened in browser tabs, closing either one of them leads to a crash. The embedding WebContentsImpl in its destructor will attempt to update screen rects for child WebContentsImpl. The children will fail to locate their parent due to their node Id not being kInvalid despite the node no longer existing (destroyed earlier in the parent WebContentsImpl dtor). ~ No longer notify children about screen rect changes when being destroyed. + Add regression test. BUG=667708 Review-Url: https://codereview.chromium.org/2519333007 Cr-Commit-Position: refs/heads/master@{#434570} (cherry picked from commit 9f43b0110e3e4b47064b067fecc30ca2ce2c193e) Committed: https://chromium.googlesource.com/chromium/src/+/57e104b5bbebdf3c7319ff89239dc9ebef7fd7c9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -1 line) Patch
M chrome/browser/apps/guest_view/web_view_browsertest.cc View 2 chunks +51 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
wjmaclean
4 years ago (2016-12-01 19:51:23 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
57e104b5bbebdf3c7319ff89239dc9ebef7fd7c9.

Powered by Google App Engine
This is Rietveld 408576698