Refactor TextFinder::scopeStringMatches().

Refactor TextFinder::scopeStringMatches().

Extract startScopingStringMatches() function.
Use single Member<DeferredScopeStringMatches> instead of a vector.

BUG=669983
Committed: https://crrev.com/b943a912b47fa31360024c78ab996f12705812a9
Cr-Commit-Position: refs/heads/master@{#435906}

[kotenkov, 2016-11-30 17:47:38]

The CQ bit was checked by kotenkov@yandex-team.ru to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 17:48:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kotenkov, 2016-11-30 18:37:31]

Description was changed from

==========
Refactor TextFinder::scopeStringMatches().

Extract startScopingStringMatches() function.
Use single Member<DeferredScopeStringMatches> instead of a vector.

BUG=
==========

to

==========
Refactor TextFinder::scopeStringMatches().

Extract startScopingStringMatches() function.
Use single Member<DeferredScopeStringMatches> instead of a vector.

BUG=669983
==========

[kotenkov, 2016-11-30 18:38:26]

kotenkov@yandex-team.ru changed reviewers:
+ dglazkov@chromium.org, tkent@chromium.org

[kotenkov, 2016-11-30 18:44:13]

I've found the mentioned bug and while working on it decided I'd refactor the
scoping first.
The two most important changes are:
- Replace the vector of DeferredScopeStringMatches with a single member. If I
understand the code correctly, there can only be one DeferredScopeStringMatches
per TextFinder at a time, so there is no need for the vector.
- Extract startScopingStringMatches() following dglazkov's comment in
TextFinder.cpp.
PTAL.

[commit-bot: I haz the power, 2016-11-30 18:56:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 18:56:58]

Dry run: This issue passed the CQ dry run.

[tkent, 2016-11-30 23:45:32]

lgtm.

On 2016/11/30 at 18:44:13, kotenkov wrote:
> - Replace the vector of DeferredScopeStringMatches with a single member. If I
understand the code correctly, there can only be one DeferredScopeStringMatches
per TextFinder at a time, so there is no need for the vector.

I'm not sure if it's true or not. I trust you.

[kotenkov, 2016-12-02 07:35:37]

The CQ bit was checked by kotenkov@yandex-team.ru

[commit-bot: I haz the power, 2016-12-02 07:35:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 10:11:20]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1480664137346390, "parent_rev":
"b0d4be9f1b9301d3a47df0fc41d437b95db3cb9e", "commit_rev":
"2e46946c03c560ee6a415eb7c21c56343f7f42e0"}

[commit-bot: I haz the power, 2016-12-02 10:11:46]

Description was changed from

==========
Refactor TextFinder::scopeStringMatches().

Extract startScopingStringMatches() function.
Use single Member<DeferredScopeStringMatches> instead of a vector.

BUG=669983
==========

to

==========
Refactor TextFinder::scopeStringMatches().

Extract startScopingStringMatches() function.
Use single Member<DeferredScopeStringMatches> instead of a vector.

BUG=669983
==========

[commit-bot: I haz the power, 2016-12-02 10:11:46]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-02 10:13:47]

Description was changed from

==========
Refactor TextFinder::scopeStringMatches().

Extract startScopingStringMatches() function.
Use single Member<DeferredScopeStringMatches> instead of a vector.

BUG=669983
==========

to

==========
Refactor TextFinder::scopeStringMatches().

Extract startScopingStringMatches() function.
Use single Member<DeferredScopeStringMatches> instead of a vector.

BUG=669983

Committed: https://crrev.com/b943a912b47fa31360024c78ab996f12705812a9
Cr-Commit-Position: refs/heads/master@{#435906}
==========

[commit-bot: I haz the power, 2016-12-02 10:13:47]

Patchset 1 (id:??) landed as
https://crrev.com/b943a912b47fa31360024c78ab996f12705812a9
Cr-Commit-Position: refs/heads/master@{#435906}