Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2546513002: Refactor TextFinder::scopeStringMatches(). (Closed)

Created:
4 years ago by kotenkov
Modified:
4 years ago
Reviewers:
tkent, dglazkov
CC:
chromium-reviews, blink-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor TextFinder::scopeStringMatches(). Extract startScopingStringMatches() function. Use single Member<DeferredScopeStringMatches> instead of a vector. BUG=669983 Committed: https://crrev.com/b943a912b47fa31360024c78ab996f12705812a9 Cr-Commit-Position: refs/heads/master@{#435906}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -125 lines) Patch
M third_party/WebKit/Source/web/TextFinder.h View 3 chunks +24 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/web/TextFinder.cpp View 7 chunks +54 lines, -61 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 chunk +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/web/tests/TextFinderTest.cpp View 9 chunks +35 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 8 chunks +34 lines, -27 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
kotenkov
I've found the mentioned bug and while working on it decided I'd refactor the scoping ...
4 years ago (2016-11-30 18:44:13 UTC) #5
tkent
lgtm. On 2016/11/30 at 18:44:13, kotenkov wrote: > - Replace the vector of DeferredScopeStringMatches with ...
4 years ago (2016-11-30 23:45:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2546513002/1
4 years ago (2016-12-02 07:35:50 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 10:11:46 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-02 10:13:47 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b943a912b47fa31360024c78ab996f12705812a9
Cr-Commit-Position: refs/heads/master@{#435906}

Powered by Google App Engine
This is Rietveld 408576698