|
|
Chromium Code Reviews
DescriptionAdd comments to wtf/AtomciString.h.
This CL has no behavior changes.
NOTRY=true
Committed: https://crrev.com/8c8664eebc5f132119492447844a66e49bdbff0e
Cr-Commit-Position: refs/heads/master@{#435581}
Patch Set 1 #
Total comments: 4
Patch Set 2 : typo #
Total comments: 2
Patch Set 3 : s #Messages
Total messages: 24 (13 generated)
The CQ bit was checked by tkent@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by tkent@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:1) has been deleted
tkent@chromium.org changed reviewers: + kochi@chromium.org
kochi@, would you review this please?
https://codereview.chromium.org/2546473004/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/wtf/text/AtomicString.h (right): https://codereview.chromium.org/2546473004/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/wtf/text/AtomicString.h:38: // instances shares their string storage if the strings are identical. Comparing s/shares/can share/ https://codereview.chromium.org/2546473004/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/wtf/text/AtomicString.h:42: // AtomicString instances are not tread-safe. An AtomicString instance created s/tread/thread/
thank you for reviewing. https://codereview.chromium.org/2546473004/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/wtf/text/AtomicString.h (right): https://codereview.chromium.org/2546473004/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/wtf/text/AtomicString.h:38: // instances shares their string storage if the strings are identical. Comparing On 2016/12/01 at 07:02:26, kochi wrote: > s/shares/can share/ Done. https://codereview.chromium.org/2546473004/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/wtf/text/AtomicString.h:42: // AtomicString instances are not tread-safe. An AtomicString instance created On 2016/12/01 at 07:02:26, kochi wrote: > s/tread/thread/ Done.
The CQ bit was checked by tkent@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
https://codereview.chromium.org/2546473004/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/wtf/text/AtomicString.h (right): https://codereview.chromium.org/2546473004/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/wtf/text/AtomicString.h:38: // instances can shares their string storage if the strings are nit: can share (without s)
https://codereview.chromium.org/2546473004/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/wtf/text/AtomicString.h (right): https://codereview.chromium.org/2546473004/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/wtf/text/AtomicString.h:38: // instances can shares their string storage if the strings are On 2016/12/01 at 07:16:56, kochi wrote: > nit: can share (without s) oops. Done.
Description was changed from ========== Add comments to wtf/AtomciString.h. This CL has no behavior changes. ========== to ========== Add comments to wtf/AtomciString.h. This CL has no behavior changes. NOTRY=true ==========
The CQ bit was checked by tkent@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from kochi@chromium.org Link to the patchset: https://codereview.chromium.org/2546473004/#ps60001 (title: "s")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1480580682794090,
"parent_rev": "3437eaa3a9ffce22c93c8a6a4f2dbb1d5007a062", "commit_rev":
"fc5a462b9743706adc85d28a8996f50b5e391f5c"}
Message was sent while issue was closed.
Committed patchset #3 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Add comments to wtf/AtomciString.h. This CL has no behavior changes. NOTRY=true ========== to ========== Add comments to wtf/AtomciString.h. This CL has no behavior changes. NOTRY=true Committed: https://crrev.com/8c8664eebc5f132119492447844a66e49bdbff0e Cr-Commit-Position: refs/heads/master@{#435581} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/8c8664eebc5f132119492447844a66e49bdbff0e Cr-Commit-Position: refs/heads/master@{#435581}
Message was sent while issue was closed.
Noticed that the title has mispelling (Atomci) :-(
Message was sent while issue was closed.
On 2016/12/01 at 08:43:49, kochi wrote: > Noticed that the title has mispelling (Atomci) :-( OMG! I shouldn't have made a CL while I was drunk. |
