Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2546473004: Add comments to wtf/AtomciString.h. (Closed)

Created:
4 years ago by tkent
Modified:
4 years ago
Reviewers:
kochi
CC:
blink-reviews, blink-reviews-wtf_chromium.org, chromium-reviews, Mikhail
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add comments to wtf/AtomciString.h. This CL has no behavior changes. NOTRY=true Committed: https://crrev.com/8c8664eebc5f132119492447844a66e49bdbff0e Cr-Commit-Position: refs/heads/master@{#435581}

Patch Set 1 #

Total comments: 4

Patch Set 2 : typo #

Total comments: 2

Patch Set 3 : s #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M third_party/WebKit/Source/wtf/text/AtomicString.h View 1 2 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (13 generated)
tkent
kochi@, would you review this please?
4 years ago (2016-12-01 06:57:08 UTC) #7
kochi
https://codereview.chromium.org/2546473004/diff/20001/third_party/WebKit/Source/wtf/text/AtomicString.h File third_party/WebKit/Source/wtf/text/AtomicString.h (right): https://codereview.chromium.org/2546473004/diff/20001/third_party/WebKit/Source/wtf/text/AtomicString.h#newcode38 third_party/WebKit/Source/wtf/text/AtomicString.h:38: // instances shares their string storage if the strings ...
4 years ago (2016-12-01 07:02:26 UTC) #8
tkent
thank you for reviewing. https://codereview.chromium.org/2546473004/diff/20001/third_party/WebKit/Source/wtf/text/AtomicString.h File third_party/WebKit/Source/wtf/text/AtomicString.h (right): https://codereview.chromium.org/2546473004/diff/20001/third_party/WebKit/Source/wtf/text/AtomicString.h#newcode38 third_party/WebKit/Source/wtf/text/AtomicString.h:38: // instances shares their string ...
4 years ago (2016-12-01 07:09:18 UTC) #9
kochi
lgtm
4 years ago (2016-12-01 07:16:16 UTC) #12
kochi
https://codereview.chromium.org/2546473004/diff/40001/third_party/WebKit/Source/wtf/text/AtomicString.h File third_party/WebKit/Source/wtf/text/AtomicString.h (right): https://codereview.chromium.org/2546473004/diff/40001/third_party/WebKit/Source/wtf/text/AtomicString.h#newcode38 third_party/WebKit/Source/wtf/text/AtomicString.h:38: // instances can shares their string storage if the ...
4 years ago (2016-12-01 07:16:57 UTC) #13
tkent
https://codereview.chromium.org/2546473004/diff/40001/third_party/WebKit/Source/wtf/text/AtomicString.h File third_party/WebKit/Source/wtf/text/AtomicString.h (right): https://codereview.chromium.org/2546473004/diff/40001/third_party/WebKit/Source/wtf/text/AtomicString.h#newcode38 third_party/WebKit/Source/wtf/text/AtomicString.h:38: // instances can shares their string storage if the ...
4 years ago (2016-12-01 08:24:30 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2546473004/60001
4 years ago (2016-12-01 08:24:59 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years ago (2016-12-01 08:30:47 UTC) #20
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/8c8664eebc5f132119492447844a66e49bdbff0e Cr-Commit-Position: refs/heads/master@{#435581}
4 years ago (2016-12-01 08:33:23 UTC) #22
kochi
Noticed that the title has mispelling (Atomci) :-(
4 years ago (2016-12-01 08:43:49 UTC) #23
tkent
4 years ago (2016-12-01 22:57:31 UTC) #24
Message was sent while issue was closed.
On 2016/12/01 at 08:43:49, kochi wrote:
> Noticed that the title has mispelling (Atomci) :-(

OMG! I shouldn't have made a CL while I was drunk.

Powered by Google App Engine
This is Rietveld 408576698