Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Issue 2546443002: Returning correct failure code on swarmed perf test run. (Closed)

Created:
4 years ago by eyaich1
Modified:
4 years ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Returning correct failure code on swarmed perf test run. Currently the rc value is not set correctly and always returns 0. Updating it to return 1 on failure so the step will turn red. Committed: https://crrev.com/a8d5dffdbf5fff11333a16599df5096736251423 Cr-Commit-Position: refs/heads/master@{#435313}

Patch Set 1 #

Patch Set 2 : Adding owners permissions #

Patch Set 3 : Remove extra line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M testing/scripts/OWNERS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M testing/scripts/run_gtest_perf_test.py View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
eyaich1
4 years ago (2016-11-30 14:22:04 UTC) #2
Paweł Hajdan Jr.
LGTM FWIW it's not clear to me how will this make behavior different, which may ...
4 years ago (2016-11-30 15:46:38 UTC) #3
eyaich1
On 2016/11/30 15:46:38, Paweł Hajdan Jr. wrote: > LGTM > > FWIW it's not clear ...
4 years ago (2016-11-30 15:58:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2546443002/40001
4 years ago (2016-11-30 15:58:52 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-11-30 17:28:12 UTC) #10
commit-bot: I haz the power
4 years ago (2016-11-30 17:31:51 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a8d5dffdbf5fff11333a16599df5096736251423
Cr-Commit-Position: refs/heads/master@{#435313}

Powered by Google App Engine
This is Rietveld 408576698